Fix SplitTooLongLine breaking long keyword names (#315)

Author: bhirsz

CHANGES.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.3.1
+
+Fix for ``SplitTooLongLine`` transformer breaking keywords with veeery long names ([#314](https://github.com/MarketSquare/robotframework-tidy/issues/314))
+
 ### Extra ``--indent`` option
 
 Robotidy normalizes all whitespaces using the same fixed amount of spaces (configurable via ``--spacecount``).

robotidy/transformers/SplitTooLongLine.py

@@ -87,6 +87,8 @@ def is_inline(node):
     def visit_KeywordCall(self, node):  # noqa
         if all(line[-1].end_col_offset < self.line_length for line in node.lines):
             return node
+        if not len(node.data_tokens) > 1:  # nothing to split anyway
+            return node
         if self.disablers.is_node_disabled(node, full_match=False):
             return node
         return self.split_keyword_call(node)
@@ -113,11 +115,9 @@ def split_keyword_call(self, node):
         separator = Token(Token.SEPARATOR, self.formatting_config.separator)
         indent = node.tokens[0]
 
-        split_every_arg = self.split_on_every_arg
         keyword = node.get_token(Token.KEYWORD)
         line = [indent, *self.join_on_separator(node.get_tokens(Token.ASSIGN), separator), keyword]
         if not self.col_fit_in_line(line):
-            split_every_arg
             head = [
                 *self.split_to_multiple_lines(node.get_tokens(Token.ASSIGN), indent=indent, separator=separator),
                 indent,

robotidy/version.py

@@ -1 +1 @@
-__version__ = "2.4"
+__version__ = "2.4.1"

tests/atest/transformers/SplitTooLongLine/expected/feed_until_line_length.robot

@@ -153,3 +153,13 @@ If - else if - else clause
 
 Too long inline IF  # shall be handled by InlineIf transformer
     ${var}    ${var2}    IF    $condition != $condition2    Longer Keyword Name    ${argument}    values    ELSE IF    $condition2    Short Keyword    ${arg}  # comment
+
+Keyword name over the limit
+    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"

tests/atest/transformers/SplitTooLongLine/expected/feed_until_line_length_4.robot

@@ -156,3 +156,13 @@ Too long inline IF  # shall be handled by InlineIf transformer
     ${var}    ${var2}    IF    $condition != $condition2    Longer Keyword Name
     ...    ${argument}    values    ELSE IF    $condition2    Short Keyword
     ...    ${arg}
+
+Keyword name over the limit
+    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"

tests/atest/transformers/SplitTooLongLine/expected/split_on_every_arg.robot

@@ -324,3 +324,13 @@ If - else if - else clause
 
 Too long inline IF  # shall be handled by InlineIf transformer
     ${var}    ${var2}    IF    $condition != $condition2    Longer Keyword Name    ${argument}    values    ELSE IF    $condition2    Short Keyword    ${arg}  # comment
+
+Keyword name over the limit
+    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"

tests/atest/transformers/SplitTooLongLine/expected/split_on_every_arg_4.robot

@@ -333,3 +333,13 @@ Too long inline IF  # shall be handled by InlineIf transformer
     ...    $condition2
     ...    Short Keyword
     ...    ${arg}
+
+Keyword name over the limit
+    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}
+    ...    ${assign}
+    ...    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"

tests/atest/transformers/SplitTooLongLine/source/tests.robot

@@ -127,3 +127,10 @@ If - else if - else clause
 
 Too long inline IF  # shall be handled by InlineIf transformer
     ${var}    ${var2}    IF    $condition != $condition2    Longer Keyword Name    ${argument}    values    ELSE IF    $condition2    Short Keyword    ${arg}  # comment
+
+Keyword name over the limit
+    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}    Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"
+
+    ${assign}    ${assign}     Enter "${VNFname}" in the field with XPath "//label[contains(text(), 'Product Name')]/../mat-form-field/div/div/div/textarea"