Do not align not templated tests in suite with Test Template (#501)

* Do not align not templated tests in suite with Test Template

Co-authored-by: Mateusz Nojek <matnojek@gmail.com>

Author: bhirsz

docs/releasenotes/4.0.0.rst

@@ -307,3 +307,14 @@ Bugs
     # robotidy: off
     # robotidy: on
     *** Settings ***
+
+- Test cases with no template will no longer be aligned together with other tests in a templated test case file (#444)::
+
+    *** Test Cases ***                  UNLINTED FILE               LINTED FILE
+    Garbage Commit Message              garbage.txt                 garbage_linted.txt
+    Valid Commit Message                unchanged.txt               unchanged_linted.txt
+    Header Validation
+        [Template]    NONE
+        ${valid header} =    Validate Header    ${header}
+        Should Be True    ${valid header}
+        ${err invalid header} =    Validate Header    ${EMPTY}

robotidy/transformers/AlignTemplatedTestCases.py

@@ -7,6 +7,7 @@
     ForHeader,
     IfHeader,
     ModelVisitor,
+    Template,
     Token,
 )
 
@@ -82,6 +83,12 @@ def visit_TestCaseSection(self, node):  # noqa
         self.widths = counter.widths
         return self.generic_visit(node)
 
+    def visit_TestCase(self, node):  # noqa
+        for statement in node.body:
+            if isinstance(statement, Template) and statement.value is None:
+                return node
+        return self.generic_visit(node)
+
     @skip_if_disabled
     def visit_Statement(self, statement):  # noqa
         if statement.type == Token.TESTCASE_NAME:
@@ -161,6 +168,12 @@ def visit_TestCaseSection(self, node):  # noqa
             self.widths[0] = 0
         self.widths = [round_to_four(length) for length in self.widths]
 
+    def visit_TestCase(self, node):  # noqa
+        for statement in node.body:
+            if isinstance(statement, Template) and statement.value is None:
+                return
+        self.generic_visit(node)
+
     @skip_if_disabled
     def visit_Statement(self, statement):  # noqa
         if statement.type == Token.COMMENT:

tests/atest/transformers/AlignTemplatedTestCases/expected/partly_templated.robot

@@ -0,0 +1,23 @@
+*** Settings ***
+Test Template       Test Commit Message
+
+
+*** Test Cases ***                  UNLINTED FILE               LINTED FILE
+Misplaced Git Trailer               misplaced_trailer.txt       misplaced_trailer_linted.txt
+Mixed Unordered List Symbols        mixed_unordered.txt         mixed_unordered_linted.txt
+Incorrectly Ordered List            ordered.txt                 ordered_linted.txt
+Unaligned List Item Indention       unaligned.txt               unaligned_linted.txt
+Garbage Commit Message              garbage.txt                 garbage_linted.txt
+Valid Commit Message                unchanged.txt               unchanged_linted.txt            ${type trailer}     ${type trailer}\n${trailer block}
+Header Validation
+    [Template]    NONE
+    ${valid header} =    Validate Header    ${header}
+    Should Be True    ${valid header}
+    ${err invalid header} =    Validate Header    ${EMPTY}
+    Should Not Be True    ${err invalid header}
+Trailer Validation
+    [Template]
+    ${valid type trailer} =    Validate Type Trailer    ${type trailer}
+    Should Be True    ${valid type trailer}
+    ${err invalid trailer} =    Validate Type Trailer    ${EMPTY}
+    Should Not Be True    ${err invalid trailer}

tests/atest/transformers/AlignTemplatedTestCases/source/partly_templated.robot

@@ -0,0 +1,23 @@
+*** Settings ***
+Test Template       Test Commit Message
+
+
+*** Test Cases ***    UNLINTED FILE    LINTED FILE
+Misplaced Git Trailer    misplaced_trailer.txt    misplaced_trailer_linted.txt
+Mixed Unordered List Symbols    mixed_unordered.txt    mixed_unordered_linted.txt
+Incorrectly Ordered List    ordered.txt    ordered_linted.txt
+Unaligned List Item Indention    unaligned.txt    unaligned_linted.txt
+Garbage Commit Message    garbage.txt    garbage_linted.txt
+Valid Commit Message    unchanged.txt    unchanged_linted.txt    ${type trailer}    ${type trailer}\n${trailer block}
+Header Validation
+    [Template]    NONE
+    ${valid header} =    Validate Header    ${header}
+    Should Be True    ${valid header}
+    ${err invalid header} =    Validate Header    ${EMPTY}
+    Should Not Be True    ${err invalid header}
+Trailer Validation
+    [Template]
+    ${valid type trailer} =    Validate Type Trailer    ${type trailer}
+    Should Be True    ${valid type trailer}
+    ${err invalid trailer} =    Validate Type Trailer    ${EMPTY}
+    Should Not Be True    ${err invalid trailer}

tests/atest/transformers/AlignTemplatedTestCases/test_transformer.py

@@ -46,3 +46,6 @@ def test_disablers(self):
 
     def test_tags(self):
         self.compare(source="tags_settings.robot", config=f"-c {self.TRANSFORMER_NAME}:enabled=True", run_all=True)
+
+    def test_partly_templated(self):
+        self.compare(source="partly_templated.robot")