Skip to content

Commit c4886d0

Browse files
authored
Task header should no longer be converted to test cases header (#221)
* task header should no longer be converted to test cases header * black
1 parent ff80c2d commit c4886d0

File tree

5 files changed

+23
-5
lines changed

5 files changed

+23
-5
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
### Fixes
66
- Trailing whitespace is no longer added to blank lines in multiline statements when using align transformers ([#219](https://github.com/MarketSquare/robotframework-tidy/issues/219))
7+
- `*** Tasks ***` is no longer converted to `*** Test Cases ***` by NormalizeSectionHeaderName ([#218](https://github.com/MarketSquare/robotframework-tidy/issues/218))
78

89
## 1.6.0
910

robotidy/transformers/NormalizeSectionHeaderName.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from robot.api.parsing import ModelTransformer, SectionHeader
1+
from robot.api.parsing import ModelTransformer, SectionHeader, Token
22

33
from robotidy.decorators import check_start_end_line
44

@@ -35,10 +35,18 @@ def __init__(self, uppercase: bool = False):
3535

3636
@check_start_end_line
3737
def visit_SectionHeader(self, node): # noqa
38-
normalized_section = SectionHeader.from_params(type=node.type)
39-
normalized_name = normalized_section.data_tokens[0].value
38+
if node.name and "task" in node.name:
39+
name = "*** Tasks ***"
40+
else:
41+
name = {
42+
Token.SETTING_HEADER: "*** Settings ***",
43+
Token.VARIABLE_HEADER: "*** Variables ***",
44+
Token.TESTCASE_HEADER: "*** Test Cases ***",
45+
Token.KEYWORD_HEADER: "*** Keywords ***",
46+
Token.COMMENT_HEADER: "*** Comments ***",
47+
}[node.type]
4048
if self.uppercase:
41-
normalized_name = normalized_name.upper()
49+
name = name.upper()
4250
# we only modify header token value in order to preserver optional data driven testing column names
43-
node.data_tokens[0].value = normalized_name
51+
node.data_tokens[0].value = name
4452
return node
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
*** Settings ***
2+
3+
*** Tasks ***
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
*** Settings ***
2+
3+
*** task ***

tests/atest/transformers/NormalizeSectionHeaderName/test_transformer.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,6 @@ def test_normalize_names_selected(self):
2222
expected='selected.robot',
2323
config=' --startline 5 --endline 6'
2424
)
25+
26+
def test_tasks(self):
27+
run_tidy_and_compare(self.TRANSFORMER_NAME, source='task.robot')

0 commit comments

Comments
 (0)