ignore python files by default (#228)

* fix excludes for files

* fix `INCLUDE_EXT` for files

* refactor `get_paths` and `iterate_dir` to use the same exclude logic with `should_parse_path`

Co-authored-by: detachhead <detachhead@users.noreply.github.com>

Author: DetachHead

robotidy/files.py

@@ -84,12 +84,21 @@ def get_gitignore(root: Path) -> PathSpec:
     return PathSpec.from_lines("gitwildmatch", lines)
 
 
-def path_is_excluded(
-    normalized_path: str,
-    pattern: Optional[Pattern[str]],
+def should_parse_path(
+    path: Path, exclude: Optional[Pattern[str]], extend_exclude: Optional[Pattern[str]], gitignore: Optional[PathSpec]
 ) -> bool:
-    match = pattern.search(normalized_path) if pattern else None
-    return bool(match and match.group(0))
+    normalized_path = str(path)
+    for pattern in (exclude, extend_exclude):
+        match = pattern.search(normalized_path) if pattern else None
+        if bool(match and match.group(0)):
+            return False
+    if gitignore is not None and gitignore.match_file(path):
+        return False
+    if path.is_file():
+        return path.suffix in INCLUDE_EXT
+    if exclude and exclude.match(path.name):
+        return False
+    return True
 
 
 def get_paths(src: Tuple[str, ...], exclude: Optional[Pattern], extend_exclude: Optional[Pattern]):
@@ -101,6 +110,8 @@ def get_paths(src: Tuple[str, ...], exclude: Optional[Pattern], extend_exclude:
             sources.add("-")
             continue
         path = Path(s).resolve()
+        if not should_parse_path(path, exclude, extend_exclude, gitignore):
+            continue
         if path.is_file():
             sources.add(path)
         elif path.is_dir():
@@ -118,18 +129,14 @@ def iterate_dir(
     gitignore: Optional[PathSpec],
 ) -> Iterator[Path]:
     for path in paths:
-        if gitignore is not None and gitignore.match_file(path):
-            continue
-        if path_is_excluded(str(path), exclude) or path_is_excluded(str(path), extend_exclude):
+        if not should_parse_path(path, exclude, extend_exclude, gitignore):
             continue
-        if path.is_dir() and exclude and not exclude.match(path.name):
+        if path.is_dir():
             yield from iterate_dir(
                 path.iterdir(),
                 exclude,
                 extend_exclude,
                 gitignore + get_gitignore(path) if gitignore is not None else None,
             )
         elif path.is_file():
-            if path.suffix not in INCLUDE_EXT:
-                continue
             yield path