do not order Remote libraries together with standard libs (#176)

Author: bhirsz

CHANGES.md

@@ -6,6 +6,7 @@
 - Ignore paths from .gitignore and ``--exclude`` option, allow to ignore paths through using ``--extend-exclude`` [#110](https://github.com/MarketSquare/robotframework-tidy/issues/110)
 - Add extra indent for arguments in Suite Setup/Teardown, Test Setup/Teardown in AlignSettingsSection [#155](https://github.com/MarketSquare/robotframework-tidy/issues/155)
 - OrderSettingsSection will now preserve order of imports. It can be configured to work as before and other settings order can be also preserved [#167](https://github.com/MarketSquare/robotframework-tidy/issues/167)
+- When ordering imports with OrderSettingsSection, Remote library will not be grouped with other standard libs [#175](https://github.com/MarketSquare/robotframework-tidy/issues/175)
 - Allow to disable selected transformers [#170](https://github.com/MarketSquare/robotframework-tidy/issues/170)
 
 ### Fixes

robotidy/transformers/OrderSettingsSection.py

@@ -232,7 +232,8 @@ def fix_eol(node):
     def sort_builtin_libs(statements):
         before, after = [], []
         for comments, statement in statements:
-            if isinstance(statement, LibraryImport) and statement.name and statement.name in STDLIBS:
+            if isinstance(statement, LibraryImport) and statement.name and statement.name != 'Remote' \
+                    and statement.name in STDLIBS:
                 before.append((comments, statement))
             else:
                 after.append((comments, statement))

tests/atest/transformers/OrderSettingsSection/expected/remote_library.robot

@@ -0,0 +1,13 @@
+*** Settings ***
+Library     Collections
+Library     DateTime
+Library     Dialogs
+Library     OperatingSystem
+Library     String
+Library     XML
+Library     Browser
+Library     RequestsLibrary
+Library     Keywords/MyUtilities.py
+Library     Remote    http://localhost:9050/    WITH NAME    JDBCDB2    # DB2
+Resource    keywords.robot
+Resource    other_stuff.robot

tests/atest/transformers/OrderSettingsSection/source/remote_library.robot

@@ -0,0 +1,13 @@
+*** Settings ***
+Library     Collections
+Library     DateTime
+Library     Dialogs
+Library     OperatingSystem
+Library     String
+Library     XML
+Library     Browser
+Library     RequestsLibrary
+Library     Keywords/MyUtilities.py
+Resource    keywords.robot
+Resource    other_stuff.robot
+Library     Remote    http://localhost:9050/    WITH NAME    JDBCDB2    # DB2

tests/atest/transformers/OrderSettingsSection/test_transformer.py

@@ -100,3 +100,10 @@ def test_invalid_token_name_in_order(self):
                           f" Custom order should be provided in comma separated list with valid group names:\n" \
                           f"['documentation', 'metadata']"
         assert expected_output in str(result.exception)
+
+    def test_remote_library_as_external(self):
+        run_tidy_and_compare(
+            self.TRANSFORMER_NAME,
+            source='remote_library.robot',
+            config=':imports_order=library,resource,variables'
+        )