Replace packaging dependency with internal version handling (#425)

Author: bhirsz

docs/releasenotes/3.3.rst

@@ -39,3 +39,4 @@ Fixes
 Other
 -----
 * Reorganized our imports to better support optional rich dependency (#419)
+* Replaced packaging dependency with internal version handling, which makes our installer lighter

robotidy/utils.py

@@ -3,6 +3,7 @@
 import os
 import re
 from enum import Enum
+from functools import total_ordering
 from typing import Iterable, List, Optional, Pattern
 
 import click
@@ -12,14 +13,43 @@
 except ImportError:  # Fails on vendored-in LSP plugin
     escape = None
 
-from packaging import version
 from robot.api.parsing import Comment, End, If, IfHeader, ModelVisitor, Token
 from robot.parsing.model import Statement
 from robot.utils.robotio import file_writer
 from robot.version import VERSION as RF_VERSION
 
-ROBOT_VERSION = version.parse(RF_VERSION)
-ROBOT_WITH_LANG = version.parse("6.0")
+
+@total_ordering
+class Version:
+    def __init__(self, major: int, minor: int, fix: int):
+        self.major = major
+        self.minor = minor
+        self.fix = fix
+
+    @classmethod
+    def parse(cls, raw_version):
+        version = re.search(r"(?P<major>[0-9]+)\.(?P<minor>[0-9]+)\.?(?P<fix>[0-9]+)*", raw_version)
+        major = int(version.group("major"))
+        minor = int(version.group("minor")) if version.group("minor") is not None else 0
+        fix = int(version.group("fix")) if version.group("fix") is not None else 0
+        return cls(major, minor, fix)
+
+    def __eq__(self, other):
+        return self.major == other.major and self.minor == other.minor and self.fix == other.fix
+
+    def __lt__(self, other):
+        if self.major != other.major:
+            return self.major < other.major
+        if self.minor != other.minor:
+            return self.minor < other.minor
+        return self.fix < other.fix
+
+    def __str__(self):
+        return f"{self.major}.{self.minor}.{self.fix}"
+
+
+ROBOT_VERSION = Version.parse(RF_VERSION)
+ROBOT_WITH_LANG = Version(6, 0, 0)
 
 
 def rf_supports_lang():

setup.py

@@ -42,7 +42,6 @@
         "robotframework>=4.0",
         "click>=7.1.2",
         "colorama>=0.4.3",
-        "packaging>=21.0",
         "pathspec>=0.9.0,<0.10.0",
         "tomli>=2.0.0",
         "rich_click==1.4",
@@ -52,6 +51,7 @@
             "coverage",
             "invoke",
             "jinja2",
+            "packaging>=21.0",
             "pyflakes==2.4.*",  #  FIXME https://github.com/klen/pylama/issues/224
             "pylama",
             "pytest",

tests/atest/transformers/__init__.py

@@ -5,17 +5,20 @@
 
 import pytest
 from click.testing import CliRunner
+from packaging import version
 from packaging.specifiers import SpecifierSet
 from rich.console import Console
+from robot.version import VERSION as RF_VERSION
 
 from robotidy.cli import cli
-from robotidy.utils import ROBOT_VERSION, decorate_diff_with_color
+from robotidy.utils import decorate_diff_with_color
 
 VERSION_MATRIX = {
     "ReplaceReturns": 5,
     "InlineIf": 5,
     "ReplaceBreakContinue": 5,
 }
+ROBOT_VERSION = version.parse(RF_VERSION)
 
 
 def display_file_diff(expected, actual):