Inspector - Fix context menu not working on non-enterable members; also fixes opening exceptions thrown by method invoking (#91)

Author: ManlyMarco

RuntimeUnityEditor.Core/Features/ContextMenu.cs

@@ -254,11 +254,9 @@ public void Show(object obj, ICacheEntry objEntry)
         {
             if (objEntry == null) throw new ArgumentNullException(nameof(objEntry));
 
-            if (obj == null && objEntry.CanEnterValue())
+            if (obj == null && objEntry.CanEnterValue()) //todo this is a bit of a hack, maybe add a CanGetValue to ICacheEntry? This is conservative to avoid triggering side effects
                 obj = objEntry.GetValue();
 
-            if (obj == null) throw new ArgumentException($"{nameof(obj)} needs to be not null or {nameof(objEntry)} has to be gettable");
-
             string name;
             switch (objEntry)
             {
@@ -309,11 +307,11 @@ public void Show(object obj, MemberInfo memberInfo, string memberFullName, Actio
             if (obj == null && getObj != null)
                 obj = getObj();
 
-            if (obj != null)
+            if (obj != null || memberInfo != null)
             {
                 _obj = obj;
                 _objMemberInfo = memberInfo ?? obj as MemberInfo;
-                _objName = memberFullName; //parentMemberInfo != null ? $"{parentMemberInfo.DeclaringType?.Name}.{parentMemberInfo.Name}" : obj.GetType().FullDescription();
+                _objName = memberFullName ?? (_objMemberInfo != null ? $"{_objMemberInfo.DeclaringType?.Name}.{_objMemberInfo.Name}" : obj?.GetType().FullDescription());
                 _setValue = setObj;
                 _getValue = getObj;
 

RuntimeUnityEditor.Core/Windows/Inspector/Inspector.cs

@@ -23,7 +23,7 @@ public sealed partial class Inspector : Window<Inspector>
         private InspectorTab GetCurrentTab() => _currentTab ?? (_currentTab = _tabs.FirstOrDefault());
         private Vector2 _tabScrollPos = Vector2.zero;
 
-        private GUIStyle _alignedButtonStyle;
+        private GUIStyle _alignedButtonStyle, _alignedButtonStyleUnclickable;
 
         internal static int MaxWindowY => (int)Instance.WindowRect.height;
 
@@ -76,16 +76,20 @@ public string SearchString
 
         private void DrawVariableNameEnterButton(ICacheEntry field)
         {
-            if (_alignedButtonStyle == null)
+            if (_alignedButtonStyle == null || _alignedButtonStyleUnclickable == null)
             {
                 _alignedButtonStyle = GUI.skin.button.CreateCopy();
                 _alignedButtonStyle.alignment = TextAnchor.MiddleLeft;
                 _alignedButtonStyle.wordWrap = true;
+                
+                _alignedButtonStyleUnclickable = _alignedButtonStyle.CreateCopy();
+                _alignedButtonStyleUnclickable.normal.background = null;
+                _alignedButtonStyleUnclickable.onNormal.background = null;
             }
 
             var canEnterValue = field.CanEnterValue();
             var val = field.GetValue();
-            if (GUILayout.Button(field.GetNameContent(), canEnterValue ? _alignedButtonStyle : GUI.skin.label, _inspectorNameWidth))
+            if (GUILayout.Button(field.GetNameContent(), canEnterValue ? _alignedButtonStyle : _alignedButtonStyleUnclickable, _inspectorNameWidth))
             {
                 if (IMGUIUtils.IsMouseRightClick())
                 {