Skip to content

Commit 6c380cd

Browse files
authored
Update GPU condition checks in frontier.mako (#1076)
1 parent ab9a1fd commit 6c380cd

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/frontier/submit.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ job_slug="$job_slug"
4848
job_device="$2"
4949
job_interface="$3"
5050
51-
. ./mfc.sh load -c f -m g
51+
. ./mfc.sh load -c f -m $([ "$2" = "gpu" ] && echo "g" || echo "c")
5252
5353
$sbatch_script_contents
5454

.github/workflows/frontier/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ fi
1616
if [ "$job_device" = "gpu" ]; then
1717
./mfc.sh test -a --rdma-mpi --max-attempts 3 -j $ngpus $device_opts -- -c frontier
1818
else
19-
./mfc.sh test -a --max-attempts 3 -j 32 -- -c frontier
19+
./mfc.sh test -a --max-attempts 3 -j 32 --no-gpu -- -c frontier
2020
fi

toolchain/templates/frontier.mako

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#SBATCH --time=${walltime}
1111
#SBATCH --cpus-per-task=7
1212
#SBATCH -C nvme
13-
% if gpu:
13+
% if gpu != 'no':
1414
#SBATCH --gpus-per-task=1
1515
#SBATCH --gpu-bind=closest
1616
% endif
@@ -34,12 +34,12 @@ ${helpers.template_prologue()}
3434
ok ":) Loading modules:\n"
3535
cd "${MFC_ROOT_DIR}"
3636
% if engine == 'batch':
37-
. ./mfc.sh load -c f -m ${'g' if gpu else 'c'}
37+
. ./mfc.sh load -c f -m ${'g' if gpu != 'no' else 'c'}
3838
% endif
3939
cd - > /dev/null
4040
echo
4141

42-
% if gpu:
42+
% if gpu != 'no':
4343
export MPICH_GPU_SUPPORT_ENABLED=1
4444
% else:
4545
export MPICH_GPU_SUPPORT_ENABLED=0
@@ -66,7 +66,7 @@ ulimit -s unlimited
6666
% if engine == 'interactive':
6767
--unbuffered --nodes ${nodes} --ntasks-per-node ${tasks_per_node} \
6868
--cpus-per-task 7 \
69-
% if gpu:
69+
% if gpu != 'no':
7070
--gpus-per-task 1 --gpu-bind closest \
7171
% endif
7272
${profiler} "${target.get_install_binpath(case)}")

0 commit comments

Comments
 (0)