Commit 64bd97e
Don't wrap SWANK:CREATE-SERVER inside BT:MAKE-THREAD
In general, a call to SWANK:CREATE-SERVER is not blocking (i.e. it
creates a thread on its own), hence wrapping it inside BT:MAKE-THREAD is
kind of redundant. The only situations for which a call to
BT:MAKE-THREAD would be required are as if:
- the underlying implementation does not support multi-threading, in
which case, a call to BT:MAKE-THREAD would fail anyway
- the user is explicitly forcing a _blocking_ communication style (i.e.
`(setf swank:*communication-style* nil)`), but since we, as the users,
are not enforcing that, then we should be good without that extra call
While at it, I also:
- made QL:QUICKLOAD calls consistent by specifying packages as strings
(previously it was a mix of strings and keywords)
- wrapped the infinite loop inside BT:MAKE-THREAD, that way the user can
interact with the image while it's running (i.e. call BT:ALL-THREADS to
confirm the Swank server is up and running)1 parent 3033746 commit 64bd97e
1 file changed
+16
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
398 | | - | |
399 | | - | |
| 397 | + | |
400 | 398 | | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
405 | 405 | | |
406 | 406 | | |
407 | 407 | | |
| |||
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
413 | | - | |
414 | | - | |
415 | | - | |
| 413 | + | |
| 414 | + | |
416 | 415 | | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
417 | 422 | | |
418 | 423 | | |
419 | 424 | | |
| |||
0 commit comments