feat: Added checkups for correct memory allocation on all strdup (malloc)

Author: XV02

src/libltfs/arch/filename_handling.c

@@ -130,6 +130,7 @@ void update_platform_safe_name(struct dentry* dentry, bool handle_invalid_char,
 		}
 	}
 #else
+	// Checkup not needed here, memory error handling happens after function calls.
 	dentry->platform_safe_name = strdup(dentry->name.name);
 #endif
 }
@@ -242,6 +243,10 @@ char * _generate_target_file_name(const char *prefix, const char *extension, int
 			ret = asprintf(&target, "%s.%s", prefix, extension);
 		else {
 			target = strdup(prefix);
+			if (!target) {
+				ltfsmsg(LTFS_ERR, 10001E, "_generate_target_file_name: target assign");
+				ret = -1;
+			}
 			ret = target ? strlen(target) : -1;
 		}
 	}

src/libltfs/fs.c

@@ -89,6 +89,7 @@ static char* generate_hash_key_name(const char *src_str, int *rc)
 	} else
 		free(uchar_name);
 #else
+	// Chek not needed here for strdup because the error is handled where the function is called
 	key_name = strdup(src_str);
 	*rc = 0;
 #endif

src/libltfs/index_criteria.c

@@ -288,27 +288,30 @@ int index_criteria_parse_name(const char *criteria, size_t len, struct index_cri
 	/* Assign rules to the glob_patterns[] array */
 	rule = rule+5;
 	for (delim = rule; *delim; delim++) {
-		if (*delim == ':') {
-			*delim = '\0';
-			rule_ptr->percent_encode = fs_is_percent_encode_required(rule);
-			rule_ptr->name = strdup(rule);
-			rule_ptr++;
-			rule = delim+1;
-		} else if (*delim == '/') {
-			*delim = '\0';
-			rule_ptr->percent_encode = fs_is_percent_encode_required(rule);
-			rule_ptr->name = strdup(rule);
-			rule_ptr++;
-		} else if (*(delim+1) == '\0') {
+			if (*delim == ':' || *delim == '/') {
+				*delim = '\0';
+			}
 			rule_ptr->percent_encode = fs_is_percent_encode_required(rule);
 			rule_ptr->name = strdup(rule);
+			if (! rule_ptr->name) {
+					ltfsmsg(LTFS_ERR, 10001E, "index_criteria_parse_name: rule assign");
+					free(rule_ptr->name);
+					return -EDEV_NO_MEMORY;
+			}
 			rule_ptr++;
-		}
+			if (*delim == ':') {
+				rule = delim+1;
+			}
 	}
 
 	if (ic->glob_patterns == rule_ptr) {
 		rule_ptr->percent_encode = fs_is_percent_encode_required(rule);
 		rule_ptr->name = strdup(rule);
+		if (! rule_ptr->name) {
+			ltfsmsg(LTFS_ERR, 10001E, "index_criteria_parse_name: glob_patterns assign");
+			free(rule_ptr->name);
+			return -EDEV_NO_MEMORY;
+		}
 	}
 
 	/* Validate rules */

src/libltfs/ltfs.c

@@ -3,7 +3,7 @@
 **  OO_Copyright_BEGIN
 **
 **
-**  Copyright 2010, 2025 IBM Corp. All rights reserved.
+**  Copyright 2010, 2020 IBM Corp. All rights reserved.
 **
 **  Redistribution and use in source and binary forms, with or without
 **   modification, are permitted provided that the following conditions
@@ -1658,8 +1658,7 @@ int ltfs_mount(bool force_full, bool deep_recovery, bool recover_extra, bool rec
 						(unsigned long long)vol->dp_coh.volume_change_ref,
 						(unsigned long long)volume_change_ref);
 
-				/* Index of IP could be corrupted. So set skip flag to true */
-				ret = _ltfs_search_index_wp(recover_symlink, true, &seekpos, vol);
+				ret = _ltfs_search_index_wp(recover_symlink, false, &seekpos, vol);
 				if (ret < 0)
 					goto out_unlock;
 
@@ -1669,7 +1668,7 @@ int ltfs_mount(bool force_full, bool deep_recovery, bool recover_extra, bool rec
 				seekpos.block = vol->dp_coh.set_id;
 			}
 		} else {
-			if (vol->ip_coh.count > vol->dp_coh.count && vollock != PWE_MAM_DP && vollock != PWE_MAM) {
+			if (vollock != PWE_MAM_DP && vollock != PWE_MAM) {
 				/*
 				 * The index on IP is newer but MAM shows write perm doesn't happen in DP.
 				 * LTFS already have written an index on DP when it is writing an index on IP,
@@ -1688,13 +1687,8 @@ int ltfs_mount(bool force_full, bool deep_recovery, bool recover_extra, bool rec
 						(unsigned long long)vol->dp_coh.volume_change_ref,
 						(unsigned long long)volume_change_ref);
 
-				if (vollock == PWE_MAM_BOTH) {
-					/* Index of IP could be corrupted (because of double write perm). So set skip flag to true */
-					ret = _ltfs_search_index_wp(recover_symlink, true, &seekpos, vol);
-				} else {
-					/* Index of DP could be corrupted. So set skip flag to false */
-					ret = _ltfs_search_index_wp(recover_symlink, false, &seekpos, vol);
-				}
+				/* Index of IP could be corrupted. So set skip flag */
+				ret = _ltfs_search_index_wp(recover_symlink, true, &seekpos, vol);
 				if (ret < 0)
 					goto out_unlock;
 

src/libltfs/ltfs_fsops.c

@@ -1912,7 +1912,12 @@ int ltfs_fsops_symlink_path(const char* to, const char* from, ltfs_file_id *id,
 
 	id->uid = d->uid;
 	id->ino = d->ino;
+	// TODO: Check if the return error is needed or can be skipped.
 	d->target.name = strdup(to);
+	if (! d->target.name) {
+		ltfsmsg(LTFS_ERR, 10001E, "ltfs_fsops_symlink_path: d target name");
+		return -LTFS_NO_MEMORY;
+	}
 	d->target.percent_encode = fs_is_percent_encode_required(to);
 	d->isslink = true;
 

src/libltfs/ltfs_internal.c

@@ -1313,6 +1313,10 @@ int ltfs_split_symlink( struct ltfs_volume *vol )
 	}
 	ret = ltfs_fsops_close( workd, true, true, use_iosche, vol);
 	path=strdup(lfdir);
+	if (! path) {
+		ltfsmsg(LTFS_ERR, 10001E, "ltfs_split_symlink: path assign");
+		return -LTFS_NO_MEMORY;
+	}
 
 	/* loop for conflicted files */
 	for( i=0; i<(vol->index->symerr_count); i++ ){

src/libltfs/ltfslogging.c

@@ -489,6 +489,11 @@ int ltfsmsg_internal(bool print_id, int level, char **msg_out, const char *_id,
 		vsprintf(msg_buf, output_buf, argp);
 		va_end(argp);
 		*msg_out = strdup(msg_buf);
+		// TODO: Check if the return -1 is needed, or the program can just continue
+		if (!(*msg_out)) {
+			ltfsmsg(LTFS_ERR, 10001E, "ltfsmsg_internal: msg_out assign");
+			return -1;
+		}
 	}
 
 #ifdef ENABLE_SNMP

src/libltfs/ltfssnmp.c

@@ -122,6 +122,10 @@ int read_trap_def_file(char *deffile)
 					return -LTFS_NO_MEMORY;
 				}
 				entry->id = strdup(tok);
+				if (!entry->id) {
+					ltfsmsg(LTFS_ERR, 10001E, "read_trap_def_file: entry id assign");
+					return -LTFS_NO_MEMORY;
+				}
 				TAILQ_INSERT_TAIL(&trap_entries, entry, list);
 			}
 		}

src/libltfs/pathname.c

@@ -953,8 +953,10 @@ int _pathname_utf8_to_system_icu(const char *src, char **dest)
 	syslocale = ucnv_getDefaultName();
 	if (! strcmp(syslocale, "UTF-8")) {
 		*dest = strdup(src);
-		if (! *dest)
+		if (! (*dest)) {
+			ltfsmsg(LTFS_ERR, 10001E, "_pathname_utf8_to_system_icu: dest assign");
 			return -LTFS_NO_MEMORY;
+		}
 		return 0;
 	}
 

src/libltfs/tape.c

@@ -1895,6 +1895,10 @@ int tape_get_media_pool_info(struct ltfs_volume *vol, char **media_name, char **
 			name = strndup(vol->t_attr->media_pool, add_start);
 		}
 		info = strdup(&(vol->t_attr->media_pool[add_start+1]));
+		if (!info) {
+			ltfsmsg(LTFS_ERR, 10001E, __FILE__);
+			return -LTFS_NO_MEMORY;
+		}
 		len = strlen(info);
 		info[len-1] = '\0';
 	}
@@ -3508,7 +3512,7 @@ int read_tape_attribute(struct ltfs_volume *vol, char **val, const char *name)
 		*val = strdup(vol->t_attr->media_pool);
 	}
 
-	if (!*val) {
+	if (!(*val)) {
 		ltfsmsg(LTFS_ERR, 10001E, "read_tape_attribute: *val");
 		return -LTFS_UNEXPECTED_VALUE;
 	}