Merge pull request #137 from yknx4/feature/use-integration-for-check-suite

feature: use integration for check suite

Author: yknx4

config/config.exs

@@ -59,7 +59,8 @@ config :event_bus,
     :pull_request_synced,
     :inserted,
     :updated,
-    :build_finished
+    :build_finished,
+    :check_suite_requested
   ]
 
 config :ueberauth, Ueberauth,

lib/librecov_web/live/build_live/job_row.ex

@@ -29,7 +29,7 @@ defmodule Librecov.RepositoryLive.JobRow do
         </span>
       </td>
       <td class="text-start d-none d-sm-table-cell">
-        {@job.run_at |> human_time_ago}
+        {(@job.run_at || @job.updated_at) |> human_time_ago}
       </td>
       <td class="text-center d-none d-sm-table-cell">
         {@job.files_count}

lib/opencov/services/github/auth.ex

@@ -18,6 +18,18 @@ defmodule Librecov.Services.Github.Auth do
 
   def with_auth_data(nil, _), do: {:error, :nil_input}
 
+  def with_auth_data(
+        %{
+          "installation" => %{"id" => installation_id},
+          "repository" => %{"name" => repo, "owner" => %{"login" => owner}}
+        },
+        block
+      ) do
+    with {:ok, token} <- login_token_for(:installation_id, installation_id) do
+      apply(block, [%AuthData{token: token, owner: owner, repo: repo}])
+    end
+  end
+
   def with_auth_data(%Project{} = project, block) do
     with {owner, repo} <- Project.name_and_owner(project) do
       with_auth_data(owner, repo, block)
@@ -53,6 +65,15 @@ defmodule Librecov.Services.Github.Auth do
     jwt
   end
 
+  def login_token_for(:installation_id, installation_id) do
+    with {:ok, token} <-
+           app_token()
+           |> Connection.new()
+           |> Apps.apps_create_installation_access_token(installation_id) do
+      {:ok, token.token}
+    end
+  end
+
   def login_token(login) do
     with {:ok, installations} <-
            app_token()

lib/opencov/services/github/checks.ex

@@ -63,6 +63,8 @@ defmodule Librecov.Services.Github.Checks do
              }
            ) do
       Logger.info("Finished check of commit #{commit} with diff: #{cov_dif} coverage: #{cov}.")
+      Logger.info("#{commit_check |> inspect() |> Jason.encode!(pretty: true)}")
+      Logger.info("#{diff_check |> inspect() |> Jason.encode!(pretty: true)}")
       {:ok, [commit_check, diff_check]}
     end
   end

lib/opencov/subscribers/github_subscriber.ex

@@ -10,7 +10,7 @@ defmodule Librecov.Subscriber.GithubSubscriber do
   alias Librecov.Templates.CommentTemplate
   alias Librecov.Services.Github.AuthData
 
-  @topics [:build_finished, :pull_request_synced]
+  @topics [:build_finished, :pull_request_synced, :check_suite_requested]
 
   def topics, do: @topics
 
@@ -39,13 +39,10 @@ defmodule Librecov.Subscriber.GithubSubscriber do
     end)
   end
 
-  def process(%Event{topic: :pull_request_synced, data: payload}) do
-    with %{"after" => commit, "repository" => repo} <- payload,
-         %{"name" => repo, "owner" => %{"login" => owner}} <- repo do
-      Auth.with_auth_data(owner, repo, fn auth ->
-        Checks.create_check(auth, commit)
-      end)
-    end
+  def process(%Event{topic: :check_suite_requested, data: payload}) do
+    Auth.with_auth_data(payload, fn auth ->
+      Checks.create_check(auth, payload["check_suite"]["head_sha"])
+    end)
   end
 
   def process(%Event{}) do

lib/opencov/templates/comment_template.ex

@@ -23,7 +23,7 @@ defmodule Librecov.Templates.CommentTemplate do
           }
         } = build,
         %{
-          head: %{user: %{login: username}},
+          user: %{login: username},
           base: %{ref: base_branch, sha: base_commit}
         }
       ) do

lib/web/services/github_service.ex

@@ -10,10 +10,22 @@ defmodule Librecov.GithubService do
     install(payload["repository"])
   end
 
+  def handle("check_suite", payload) do
+    handle_check_suite(payload["action"], payload)
+  end
+
   def handle(event, _payload) do
     Logger.debug("Unhandled event: #{event}")
   end
 
+  defp handle_check_suite(action, payload) when action in ["rerequested", "requested"] do
+    %Event{id: UUID.uuid1(), topic: :check_suite_requested, data: payload} |> EventBus.notify()
+  end
+
+  defp handle_check_suite(action, _payload) do
+    Logger.debug("Unhandled action: #{action}")
+  end
+
   def handle_pr("synchronize", payload) do
     %Event{id: UUID.uuid1(), topic: :pull_request_synced, data: payload} |> EventBus.notify()
   end

test/lib/templates/comments_template_test.exs

@@ -17,7 +17,7 @@ defmodule Librecov.Templates.CommentTemplateTest do
   test "barebones template #1" do
     template =
       CommentTemplate.coverage_message(@base_build, %{
-        head: %{user: %{login: "github"}},
+        user: %{login: "github"},
         base: %{ref: "potato", sha: "chettos"}
       })
 
@@ -28,7 +28,7 @@ defmodule Librecov.Templates.CommentTemplateTest do
   test "barebones template #2" do
     template =
       CommentTemplate.coverage_message(%Build{@base_build | coverage: 50.1234}, %{
-        head: %{user: %{login: "github"}},
+        user: %{login: "github"},
         base: %{ref: "potato", sha: "chettos"}
       })
 
@@ -41,7 +41,7 @@ defmodule Librecov.Templates.CommentTemplateTest do
       CommentTemplate.coverage_message(
         %Build{@base_build | coverage: 50.1234, previous_coverage: 30.2345},
         %{
-          head: %{user: %{login: "github"}},
+          user: %{login: "github"},
           base: %{ref: "potato", sha: "chettos"}
         }
       )

test/librecov_web/live/build_live_test.exs

@@ -24,7 +24,7 @@ defmodule LibrecovWeb.BuildLiveTest do
         commit_sha: "",
         commit_message: "oie shi",
         branch: "main",
-        inserted_at: Timex.now() |> Timex.beginning_of_day() |> Timex.to_datetime(),
+        inserted_at: Timex.now() |> Timex.shift(hours: -18) |> Timex.to_datetime(),
         project: project
       )
 

test/librecov_web/live/repository_live_test.exs

@@ -334,7 +334,7 @@ defmodule Librecov.RepositoryLiveTest do
         commit_sha: "",
         commit_message: "oie shi",
         branch: "main",
-        inserted_at: Timex.now() |> Timex.beginning_of_day() |> Timex.to_datetime(),
+        inserted_at: Timex.now() |> Timex.shift(hours: -18) |> Timex.to_datetime(),
         project: p
       )