Skip to content

Commit eca33ba

Browse files
committed
Moved IConfigurationSerializer interface one level up
1 parent 39d8162 commit eca33ba

File tree

5 files changed

+5
-19
lines changed

5 files changed

+5
-19
lines changed

src/Objects/IConfigurationSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
using System.Collections.Generic;
22

3-
namespace Kralizek.Extensions.Configuration.Internal;
3+
namespace Kralizek.Extensions.Configuration;
44

55
public interface IConfigurationSerializer
66
{

src/Objects/ObjectConfigurationExtensions.cs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using Kralizek.Extensions.Configuration;
23
using Kralizek.Extensions.Configuration.Internal;
34

45
// ReSharper disable CheckNamespace
@@ -13,13 +14,8 @@ public static IConfigurationBuilder AddObject(this IConfigurationBuilder configu
1314
{
1415
return configurationBuilder;
1516
}
16-
17-
if (rootSectionName == null)
18-
{
19-
throw new ArgumentNullException(nameof(rootSectionName));
20-
}
2117

22-
configurationBuilder.Add(new ObjectConfigurationSource(serializer, objectToAdd, rootSectionName));
18+
configurationBuilder.Add(new ObjectConfigurationSource(serializer, objectToAdd, rootSectionName ?? string.Empty));
2319

2420
return configurationBuilder;
2521
}

tests/Tests.Objects/Internal/ObjectConfigurationProviderTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using AutoFixture.Idioms;
22
using AutoFixture.NUnit3;
3+
using Kralizek.Extensions.Configuration;
34
using Kralizek.Extensions.Configuration.Internal;
45
using Moq;
56
using NUnit.Framework;

tests/Tests.Objects/NewtonsoftJsonObjectConfigurationExtensionsTests.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using Microsoft.Extensions.Configuration;
44
using Moq;
55
using NUnit.Framework;
6+
// ReSharper disable InvokeAsExtensionMethod
67

78
namespace Tests;
89

@@ -34,10 +35,4 @@ public void AddObject_does_nothing_when_source_is_null(IConfigurationBuilder con
3435

3536
Mock.Get(configurationBuilder).Verify(p => p.Add(It.IsAny<IConfigurationSource>()), Times.Never);
3637
}
37-
38-
[Test, CustomAutoData]
39-
public void AddObject_throws_if_rootSectionName_is_null(IConfigurationBuilder configurationBuilder, object testSource)
40-
{
41-
Assert.Throws<ArgumentNullException>(() => NewtonsoftJsonObjectConfigurationExtensions.AddObjectWithNewtonsoftJson(configurationBuilder, testSource, null));
42-
}
4338
}

tests/Tests.Objects/SystemTextJsonObjectConfigurationExtensionsTests.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,4 @@ public void AddObject_does_nothing_when_source_is_null(IConfigurationBuilder con
3535

3636
Mock.Get(configurationBuilder).Verify(p => p.Add(It.IsAny<IConfigurationSource>()), Times.Never);
3737
}
38-
39-
[Test, CustomAutoData]
40-
public void AddObject_throws_if_rootSectionName_is_null(IConfigurationBuilder configurationBuilder, object testSource)
41-
{
42-
Assert.Throws<ArgumentNullException>(() => ObjectConfigurationExtensions.AddObject(configurationBuilder, testSource, null));
43-
}
4438
}

0 commit comments

Comments
 (0)