Skip to content

Commit 77d66b1

Browse files
committed
bug fix
1 parent f4c625b commit 77d66b1

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

src/html/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,17 @@
5454
<div class="column">
5555
<div class="mySelect 3D">
5656
<span id='xLabel'>X</span>
57-
<select class="testSelect sWheel" id="xCol"></select>
57+
<select class="sWheel" id="xCol"></select>
5858
</div>
5959

6060
<div class="mySelect">
6161
<span id='yLabel'>Y</span>
62-
<select class="testSelect sWheel" id="yCol"></select>
62+
<select class="sWheel" id="yCol"></select>
6363
</div>
6464

6565
<div class="mySelect">
6666
<span id='zLabel'>Z</span>
67-
<select class="testSelect sWheel" id="zCol"></select>
67+
<select class="sWheel" id="zCol"></select>
6868
<span id="intSwap">&#8646;</span>
6969
<select class="sWheel" id="sCol"></select>
7070
</div>

src/js/functions.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -72,10 +72,10 @@ function setUpColumns() {
7272
sCol.selectedIndex = col.s;
7373
}
7474

75-
xCol.onchange = yCol.onchange = updateData
76-
zCol.onchange = (ev) => { colChanged(ev.target.selectedIndex); window.dispatchEvent(new Event('columnChanged')) }
77-
7875

76+
xCol.addEventListener('change', (ev) => { updateData() })
77+
yCol.addEventListener('change', (ev) => { updateData() })
78+
zCol.addEventListener('change', (ev) => { colChanged(ev.target.selectedIndex); window.dispatchEvent(new Event('columnChanged')) })
7979

8080
function updateData(init = false, all = true) {
8181
if (!init) {
@@ -84,7 +84,6 @@ function updateData(init = false, all = true) {
8484
col.z = zCol.selectedIndex;
8585
}
8686
th_in = 0;
87-
8887
if (!swapped) {
8988
store.set(is3D ? "cols3d" : "cols2d", col)
9089
} else {
@@ -360,7 +359,7 @@ function startDragBehavior() {
360359
});
361360
drag.on("dragend", () => {
362361
fullData[currentEditable] = data
363-
saved= false;
362+
saved = false;
364363
viewer3D.update()
365364
})
366365
d3.selectAll(`.scatterlayer .trace:nth-of-type(${currentEditable + 1}) .points path`).call(drag);
@@ -388,7 +387,7 @@ class Viewer_3D {
388387
isOpen = () => {
389388
return this.viewerWindow
390389
}
391-
390+
392391

393392
open = () => {
394393
if (this.viewerWindow) {
@@ -428,8 +427,8 @@ class Viewer_3D {
428427
}, 500) // a half second pause before sending the data
429428
}
430429

431-
close =()=>{
432-
if(this.viewerWindow) this.viewerWindow.close();
430+
close = () => {
431+
if (this.viewerWindow) this.viewerWindow.close();
433432
}
434433
}
435434

0 commit comments

Comments
 (0)