[BREAKING] Update ISUPPORT MODES to accurately be int-optional

Author: mbax

src/main/java/org/kitteh/irc/client/library/command/ChannelModeCommand.java

@@ -121,8 +121,8 @@ public synchronized void execute() {
         }
         int parameterModesPerLine = -1;
         Optional<ISupportParameter.Modes> modes = this.getClient().getServerInfo().getISupportParameter("MODES", ISupportParameter.Modes.class);
-        if (modes.isPresent()) {
-            parameterModesPerLine = modes.get().getInteger();
+        if (modes.isPresent() && modes.get().getInteger().isPresent()) {
+            parameterModesPerLine = modes.get().getInteger().getAsInt();
         }
         if (parameterModesPerLine < 1) {
             parameterModesPerLine = ChannelModeCommand.PARAMETER_MODES_PER_LINE;

src/main/java/org/kitteh/irc/client/library/defaults/element/isupport/DefaultISupportModes.java

@@ -31,7 +31,7 @@
 /**
  * Default implementation of {@link ISupportParameter.Modes}.
  */
-public class DefaultISupportModes extends DefaultISupportParameterInteger implements ISupportParameter.Modes {
+public class DefaultISupportModes extends DefaultISupportParameterOptionalInteger implements ISupportParameter.Modes {
     /**
      * Constructs the object.
      *

src/main/java/org/kitteh/irc/client/library/element/ISupportParameter.java

@@ -364,7 +364,7 @@ interface KickLen extends IntegerParameter {
     /**
      * Represents the number of modes with parameters allowed per line.
      */
-    interface Modes extends IntegerParameter {
+    interface Modes extends OptionalIntegerParameter {
         /**
          * Parameter name.
          */

src/test/java/org/kitteh/irc/client/library/command/ChannelModeCommandTest.java

@@ -16,6 +16,7 @@
 import org.mockito.Mockito;
 
 import java.util.Optional;
+import java.util.OptionalInt;
 
 /**
  * @see ChannelModeCommand
@@ -37,7 +38,7 @@ public void before() {
         Mockito.when(serverInfo.isValidChannel(Mockito.any())).thenReturn(true);
         ISupportParameter.Modes modes = Mockito.mock(ISupportParameter.Modes.class);
         Mockito.when(serverInfo.getISupportParameter("MODES", ISupportParameter.Modes.class)).thenReturn(Optional.of(modes));
-        Mockito.when(modes.getInteger()).thenReturn(3);
+        Mockito.when(modes.getInteger()).thenReturn(OptionalInt.of(3));
     }
 
     @Test