fix: correct JSON handling and improve code quality

- Update JsonCaster to properly decode JSON strings
- Modify TypeSystem to ensure correct registration of JsonCaster
- Refactor testEnvVariable for accurate JSON type detection

This commit addresses the issue where JSON values were incorrectly
identified as strings and improves overall code quality:

- JsonCaster now correctly decodes JSON and handles errors robustly
- TypeSystem explicitly registers JsonCaster for consistent processing
- testEnvVariable function now accurately detects and reports JSON types

Additional improvements:
- Enhance error handling in JsonCaster using JSON_THROW_ON_ERROR
- Improve TypeSystem constructor with optional dependency injection
- Split testEnvVariable logic into smaller, more focused functions

Author: walmir-silva

src/Type/Caster/JsonCaster.php

@@ -2,28 +2,40 @@
 
 declare(strict_types=1);
 
-declare(strict_types=1);
-
 namespace KaririCode\Dotenv\Type\Caster;
 
 use KaririCode\Dotenv\Contract\TypeCaster;
 
 class JsonCaster implements TypeCaster
 {
-    public function canCast(mixed $value): bool
+    /**
+     * @throws \JsonException
+     */
+    public function cast(mixed $value): mixed
     {
         if (!is_string($value)) {
-            return false;
+            return $value;
         }
 
-        $trimmed = trim($value);
+        $trimmedValue = $this->removeSurroundingQuotes($value);
 
-        return (str_starts_with($trimmed, '{') && str_ends_with($trimmed, '}'))
-               || (str_starts_with($trimmed, '[') && str_ends_with($trimmed, ']'));
+        return $this->decodeJson($trimmedValue);
     }
 
-    public function cast(mixed $value): mixed
+    private function removeSurroundingQuotes(string $value): string
     {
-        return json_encode($value);
+        return trim($value, '"\'');
+    }
+
+    /**
+     * @throws \JsonException
+     */
+    private function decodeJson(string $json): mixed
+    {
+        try {
+            return json_decode($json, true, 512, JSON_THROW_ON_ERROR);
+        } catch (\JsonException $e) {
+            return $json;
+        }
     }
 }

tests/application.php

@@ -56,17 +56,32 @@
 function testEnvVariable(string $key, string $expectedType): void
 {
     $value = env($key);
-    $actualType = gettype($value);
+    $actualType = determineActualType($value, $expectedType);
 
+    outputTestResult($key, $value, $expectedType, $actualType);
+
+    if ($actualType !== $expectedType) {
+        echo "WARNING: Type mismatch for $key\n";
+    }
+}
+
+function determineActualType(mixed $value, string $expectedType): string
+{
+    if ('json' === $expectedType && (is_array($value) || is_object($value))) {
+        return 'json';
+    }
+
+    return gettype($value);
+}
+
+function outputTestResult(string $key, mixed $value, string $expectedType, string $actualType): void
+{
+    $displayValue = is_array($value) || is_object($value) ? json_encode($value) : var_export($value, true);
     echo sprintf(
         "%s: %s (Expected: %s, Actual: %s)\n",
         $key,
-        is_array($value) || is_object($value) ? json_encode($value) : var_export($value, true),
+        $displayValue,
         $expectedType,
         $actualType
     );
-
-    if ($actualType !== $expectedType) {
-        echo "WARNING: Type mismatch for $key\n";
-    }
 }