Replies: 3 comments 2 replies
-
|
If we remove the release 0.22, even if we got breaking changes with some previous commits, we can do modifications to revert them or make them non-breaking. |
Beta Was this translation helpful? Give feedback.
-
|
I will try to explain clearly why the situation is very problematic on my side, and why the (core) issues we are seeing are not caused by the code itself. I polished my answer 😉 Is the new
|
Beta Was this translation helpful? Give feedback.
-
|
My plan was to upgrade all the JSO packages to NLPModels 0.22. Most of the important changes had already been prepared by someone else, and I had already scheduled time to coordinate the update across the organization myself — which usually takes about two days. Outside the organization, I’m of course happy to help, but I’m not responsible for coordinating updates there. Changing a function signature is indeed rare, but in this case it’s a relatively straightforward modification. The only time-consuming part is bumping the versions, and we had good momentum, with several people available to work on it. This did not assume that you would have to handle it, Alexis. In my opinion, yanking the release and re-adding code to maintain the deprecated signature only postpones the issue. I had the opportunity to update things quickly, which is why the release was made. For urgent code extending the extension, you can always add code directly in the package where you use it and later add it to NLPModels also. Despite all this, I’m completely fine with going with the majority decision from here. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@amontoison @tmigot
I'm opening this discussion to better understand the situation and so we can discuss a path forward.
The good news is that, currently, nothing is broken if no package upgrades to 0.22.
Things I need to understand:
jac_lin_coordthe only offending change?Observations open for comments:
main, any future release will contain them. So I don't see how removing the release solves anything.Beta Was this translation helpful? Give feedback.
All reactions