Fix dispatch for criteria

Author: Frankie Robertson

src/next_item_rules/prelude/abstract.jl

@@ -32,9 +32,9 @@ $(TYPEDEF)
 Abstract base type all criteria should inherit from
 """
 abstract type CriterionBase <: CatConfigBase end
-abstract type ItemCriterionBase <: CatConfigBase end
+abstract type SubItemCriterionBase <: CatConfigBase end
 
-abstract type ItemCriterion <: ItemCriterionBase end
+abstract type ItemCriterion <: CatConfigBase end
 
 """
 $(TYPEDEF)
@@ -44,17 +44,17 @@ abstract type StateCriterion <: CriterionBase end
 """
 $(TYPEDEF)
 """
-abstract type PointwiseItemCriterion <: ItemCriterionBase end
+abstract type PointwiseItemCriterion <: SubItemCriterionBase end
 
 """
 $(TYPEDEF)
 """
-abstract type ItemCategoryCriterion <: ItemCriterionBase end
+abstract type ItemCategoryCriterion <: SubItemCriterionBase end
 
 """
 $(TYPEDEF)
 """
-abstract type PointwiseItemCategoryCriterion <: ItemCriterionBase end
+abstract type PointwiseItemCategoryCriterion <: SubItemCriterionBase end
 
 abstract type MatrixScalarizer end
 abstract type StateMultiCriterion end

src/next_item_rules/prelude/criteria.jl

@@ -90,7 +90,7 @@ function compute_criteria(
 end
 
 function compute_criterion(
-        ppic::ItemCriterionBase, tracked_responses::TrackedResponses, item_idx, args...)
+        ppic::SubItemCriterionBase, tracked_responses::TrackedResponses, item_idx, args...)
     compute_criterion(ppic, ItemResponse(tracked_responses.item_bank, item_idx), args...)
 end