Refactor TableSelection #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the internal
TableSelectiontype to avoid runtime checks in the wrong places. This type is intended for developers of TableTransforms.jl so the only check that should occur about the columns names is in the constructor. All further calls to Tables.getcolumn should assume the existence of columns for performance.I also refactored the field type to a static tuple to improve the performance in downstream algorithm given the number of columns at compile time. It is also more consistent with other table types that return tuples in Tables.columnnames.
@eliascarv is there any particular reason we used Vector{Symbol} for the names or are we ok replacing it with tuple?