Skip to content

Commit c63b5b9

Browse files
authored
make HyperDualNumbers.jl a weak dependency (#180)
* make HyperDualNumbers a weak dependency * bump version
1 parent a37ae26 commit c63b5b9

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

Project.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "Octavian"
22
uuid = "6fd5a793-0b7e-452c-907f-f8bfe9c57db4"
33
authors = ["Chris Elrod", "Dilum Aluthge", "Mason Protter", "contributors"]
4-
version = "0.3.23"
4+
version = "0.3.24"
55

66
[deps]
77
CPUSummary = "2a0fbf3d-bb9c-48f3-b0a9-814d99fd7ab9"
@@ -19,9 +19,11 @@ VectorizationBase = "3d5dd08c-fd9d-11e8-17fa-ed2836048c2f"
1919

2020
[weakdeps]
2121
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
22+
HyperDualNumbers = "50ceba7f-c3ee-5a84-a6e8-3ad40456ec97"
2223

2324
[extensions]
2425
ForwardDiffExt = "ForwardDiff"
26+
HyperDualNumbersExt = "HyperDualNumbers"
2527

2628
[compat]
2729
CPUSummary = "0.1.26, 0.2.1"

src/Octavian.jl

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,17 +65,16 @@ include("complex_matmul.jl")
6565

6666
include("init.jl") # `Octavian.__init__()` is defined in this file
6767

68-
# TODO: This loads ForwardDiff unconditionally on Julia v1.6 - v1.8.
68+
# TODO: This loads ForwardDiff.jl and HyperDualNumbers.jl
69+
# unconditionally on Julia v1.6 - v1.8.
6970
# It could be reconsidered when these older versions are not supported
70-
# anymore. In this case, ForwardDiff should be removed from the
71-
# dependencies and treated as weak dependency.
71+
# anymore. In this case, these packages should be removed from the
72+
# dependencies and treated only as weak dependency.
7273
if !isdefined(Base, :get_extension)
7374
include("../ext/ForwardDiffExt.jl")
75+
include("../ext/HyperDualNumbersExt.jl")
7476
end
7577

76-
# TODO: confirm when we need this extension
77-
include("../ext/HyperDualNumbersExt.jl")
78-
7978
@static if VERSION >= v"1.8.0-beta1"
8079
@setup_workload begin
8180
# Putting some things in `setup` can reduce the size of the

0 commit comments

Comments
 (0)