row/colsupport for QL/QRPackedQ (#62)

* row/colsupport for QL/QRPackedQ

* v2.1.3

Author: dlfivefifty

.github/workflows/TagBot.yml

@@ -1,17 +1,14 @@
 name: TagBot
 on:
-  issue_comment:
+  issue_comment:  # THIS BIT IS NEW
     types:
       - created
   workflow_dispatch:
-    inputs:
-      lookback:
-        default: 3
-permissions:
-  contents: write
 jobs:
   TagBot:
+    # THIS 'if' LINE IS NEW
     if: github.event_name == 'workflow_dispatch' || github.actor == 'JuliaTagBot'
+    # NOTHING BELOW HAS CHANGED
     runs-on: ubuntu-latest
     steps:
       - uses: JuliaRegistries/TagBot@v1

Project.toml

@@ -1,6 +1,6 @@
 name = "MatrixFactorizations"
 uuid = "a3b82374-2e81-5b9e-98ce-41277c0e4c87"
-version = "2.1.2"
+version = "2.1.3"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
@@ -9,7 +9,7 @@ Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 
 [compat]
-ArrayLayouts = "1.0"
+ArrayLayouts = "1.9.2"
 julia = "1.9"
 
 [extras]

src/MatrixFactorizations.jl

@@ -1,6 +1,6 @@
 module MatrixFactorizations
 using Base, LinearAlgebra, ArrayLayouts
-import Base: axes, axes1, getproperty, iterate, tail
+import Base: axes, axes1, getproperty, iterate, tail, oneto
 import LinearAlgebra: BlasInt, BlasReal, BlasFloat, BlasComplex, axpy!,
    copy_oftype, checksquare, adjoint, transpose, AdjOrTrans, HermOrSym,
    det, logdet, logabsdet, isposdef
@@ -34,7 +34,7 @@ import Base: convert, size, view, unsafe_indices,
 import ArrayLayouts: reflector!, reflectorApply!, materialize!, @_layoutlmul, @_layoutrmul,
    MemoryLayout, adjointlayout, AbstractQLayout, QRPackedQLayout,
    QRCompactWYQLayout, AdjQRCompactWYQLayout, QRPackedLayout, AdjQRPackedQLayout,
-   layout_getindex
+   layout_getindex, rowsupport, colsupport
 
 
 export ul, ul!, ql, ql!, qrunblocked, qrunblocked!, UL, QL, reversecholesky, reversecholesky!, ReverseCholesky

src/ql.jl

@@ -316,6 +316,12 @@ adjointlayout(::Type, ::QLPackedQLayout{SLAY,TLAY}) where {SLAY,TLAY} = AdjQLPac
 MemoryLayout(::Type{<:QLPackedQ{<:Any,Mat,Tau}}) where {Mat,Tau} = 
     QLPackedQLayout{typeof(MemoryLayout(Mat)),typeof(MemoryLayout(Tau))}()
 
+colsupport(::QLPackedQLayout, Q, j) = minimum(colsupport(Q.factors, j)):size(Q,1)
+rowsupport(::QLPackedQLayout, Q, k) = oneto(maximum(rowsupport(Q.factors, k)))
+colsupport(::AdjQLPackedQLayout, Q, j) = oneto(maximum(colsupport(Q'.factors, j)))
+rowsupport(::AdjQLPackedQLayout, Q, k) = minimum(rowsupport(Q'.factors, k)):size(Q,2)
+
+
 
 function materialize!(M::Lmul{<:QLPackedQLayout})
     A,B = M.A, M.B