Skip to content

Commit ec57665

Browse files
authored
Typos in README.md
1 parent c855801 commit ec57665

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ PackageCompiler.revert()
3333

3434
- You might need to tweak your runtest, since SnoopCompile can have problems with some statements. Please open issues about concrete problems! This is also why there is a way to point to a file different from runtests.jl, for the case it becomes impossible to combine testing and snoop compiling (just pass `("package", "snoopfile.jl")`)!
3535

36-
- non const globals are problematic, or globals defined in functions - removing those got me to 95% of making the package save for static compilation
36+
- non const globals are problematic, or globals defined in functions - removing those got me to 95% of making the package safe for static compilation
3737

3838
- type unstable code had some inference issues (around 2 occurrence, where I’m still not sure what was happening) - both cases happened with dictionaries… Only way to find those was investigating the segfaults with `gdb`, but then it was relatively easy to just juggle around the code, since the stacktraces accurately pointed to the problem. The non const globals might be related since they introduce type instabilities.
3939

@@ -42,4 +42,4 @@ PackageCompiler.revert()
4242
- I uncovered one out of bounds issue, that somehow was not coming up without static-compilation
4343
- I used julia-debug to uncover most bugs, but actually, the last errors I was trying to uncover where due to using julia-debug!
4444

45-
- you’re pretty much on your own and need to use gdb to find the issues and I still don’t know what the underlying julia issues are and when they will get fixed :wink: See: https://github.com/JuliaLang/julia/issues/2453330. Hopefully we look at a better story with Julia 1.0!
45+
- you’re pretty much on your own and need to use gdb to find the issues and I still don’t know what the underlying julia issues are and when they will get fixed :wink: See: https://github.com/JuliaLang/julia/issues/24533. Hopefully we look at a better story with Julia 1.0!

0 commit comments

Comments
 (0)