Skip to content

Commit 41260b0

Browse files
committed
Update TODO comments
1 parent 576ed16 commit 41260b0

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/PackageCompiler.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ function copy_system_image(src, dest, ignore_missing = false)
3232
end
3333

3434
julia_cpu_target(x) = error("CPU target needs to be a string or `nothing`")
35-
julia_cpu_target(x::String) = x # TODO match against available targets
35+
julia_cpu_target(x::String) = x # TODO: match against available targets
3636
function julia_cpu_target(::Nothing)
3737
replace(Base.julia_cmd().exec[2], "-C" => "")
3838
end

src/static_julia.jl

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -315,8 +315,7 @@ function build_exec(e_file, cprog, s_file, builddir, verbose, optimize, debug, c
315315
command = `$command -Wl,-rpath,\$ORIGIN`
316316
end
317317
if Int == Int32
318-
# TODO this was added because of an error with julia on win32 that suggested this line.
319-
# Seems to work, not sure if it's correct
318+
# TODO: this was added because of an error with julia on win32 that suggested this line, it seems to work but I'm not sure if it's correct
320319
command = `$command -march=pentium4`
321320
end
322321
verbose && println("Build executable $(repr(e_file)):\n $command")
@@ -352,7 +351,7 @@ function copy_files_array(files_array, builddir, verbose, message)
352351
end
353352

354353
function copy_julia_libs(builddir, verbose)
355-
# TODO: these flags should probably be emitted from `julia-config.jl` / `compiler_flags.jl` also:
354+
# TODO: these flags should probably be emitted also by `julia-config.jl` and `compiler_flags.jl`
356355
shlibdir = Sys.iswindows() ? Sys.BINDIR : joinpath(Sys.BINDIR, Base.LIBDIR)
357356
private_shlibdir = joinpath(Sys.BINDIR, Base.PRIVATE_LIBDIR)
358357
libfiles = String[]

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ using PackageCompiler, Test
33
# If this works without error we should be in pretty good shape!
44
# This command will use the `runtest.jl` of `ColorTypes` + `FixedPointNumbers` to find out what functions to precompile!
55
compile_package("ColorTypes", "FixedPointNumbers", force = false, reuse = false) # false to not force overwriting julia's current system image
6-
# build again, with resuing the snoop file
6+
# Build again, reusing the snoop file
77
img_file = compile_package("ColorTypes", "FixedPointNumbers", force = false, reuse = true)
8-
# TODO test revert - I suppose i wouldn't have enough rights on travis to move around dll's?
8+
# TODO: I would like to test `revert` as well, but I suppose I wouldn't have enough rights on Travis CI to move around dll's?
99
julia = Base.julia_cmd().exec[1]
1010
@testset "basic tests" begin
1111
@test isfile(img_file)

0 commit comments

Comments
 (0)