Disable inplace accumulation for Symmertic/Hermitian because JuliaLang/julia#38056

Author: oxinabox

src/accumulation.jl

@@ -56,6 +56,13 @@ function is_inplaceable_destination(x::AbstractArray)
     return is_inplaceable_destination(p)
 end
 
+# Hermitian and Symmetric are too fussy to deal with right now
+# https://github.com/JuliaLang/julia/issues/38056
+# TODO: https://github.com/JuliaDiff/ChainRulesCore.jl/issues/236
+is_inplaceable_destination(::LinearAlgebra.Hermitian) = false
+is_inplaceable_destination(::LinearAlgebra.Symmetric) = false
+
+
 function debug_add!(accumuland, t::InplaceableThunk)
     returned_value = t.add!(accumuland)
     if returned_value !== accumuland

test/accumulation.jl

@@ -11,11 +11,14 @@
         @test is_inplaceable_destination(view([1, 2, 3, 4], :, :))
         @test !is_inplaceable_destination(view(1:4, :, :))
 
-        @test !is_inplaceable_destination(1.3)
         @test is_inplaceable_destination(falses(4))
         @test is_inplaceable_destination(spzeros(4))
         @test is_inplaceable_destination(spzeros(2, 2))
+
+        @test !is_inplaceable_destination(1.3)
         @test !is_inplaceable_destination(@SVector [1, 2, 3])
+        @test !is_inplaceable_destination(Hermitian([1 2; 2 4]))
+        @test !is_inplaceable_destination(Symmetric([1 2; 2 4]))
     end
 
     @testset "add!!" begin