From 687f2d02611e68b72b275ad13d08db8ebeca06d7 Mon Sep 17 00:00:00 2001 From: Morten Piibeleht Date: Thu, 31 Oct 2024 17:35:35 +1300 Subject: [PATCH 1/2] test: work around missing method error in JET --- src/jobsubmission.jl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/jobsubmission.jl b/src/jobsubmission.jl index 7b125931d..1d01d895e 100644 --- a/src/jobsubmission.jl +++ b/src/jobsubmission.jl @@ -1246,7 +1246,10 @@ function submit_job( else c.env end - args = merge(get(app, :args, Dict()), args) + args = merge( + get(app, :args, Dict())::Dict, + args, + ) projectid = isnothing(c.project) ? nothing : string(c.project) From 7b73bc9d83f215333cbd19038745f55b580e04e2 Mon Sep 17 00:00:00 2001 From: Morten Piibeleht Date: Thu, 31 Oct 2024 17:39:51 +1300 Subject: [PATCH 2/2] add a comment --- src/jobsubmission.jl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/jobsubmission.jl b/src/jobsubmission.jl index 1d01d895e..d22e05d49 100644 --- a/src/jobsubmission.jl +++ b/src/jobsubmission.jl @@ -1247,6 +1247,8 @@ function submit_job( c.env end args = merge( + # Note: we need to ::Dict type assertion here to avoid JET complaining with: + # no matching method found `convert(::Type{Dict}, ::NamedTuple)`: convert(JuliaHub.Dict, _26::NamedTuple) get(app, :args, Dict())::Dict, args, )