Skip to content

Commit 72b8fa3

Browse files
committed
add two-arg fill!
1 parent 3ccf553 commit 72b8fa3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "AxisKeysExtra"
22
uuid = "b7a0d2b7-1990-46dc-b5dd-87820ecd1b09"
33
authors = ["Alexander Plavin <alexander@plav.in>"]
4-
version = "0.1.25"
4+
version = "0.1.26"
55

66
[deps]
77
AxisKeys = "94b1ba4f-4ee9-5380-92f1-94cde586c3c5"

ext/MakieExt.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,8 @@ is_revrange(x::AbstractVector) = false
170170
is_revrange(x::AbstractRange) = step(x) < zero(step(x))
171171

172172
# pirate Base function for now, so that several packages can avoid depending on each other
173-
function Base.fill!(ax::Makie.AbstractAxis, plot::Plot, attrs::NamedTuple)
173+
# XXX: don't remember, why do we need attrs argument here? could we just always call default_*_attributes again?
174+
function Base.fill!(ax::Makie.AbstractAxis, plot::Plot, attrs::NamedTuple = (axis=default_axis_attributes(plot), plot=default_plot_attributes(plot)))
174175
for (k, v) in pairs(attrs.axis)
175176
upd_axplt_attr!(ax, k, v)
176177
end

0 commit comments

Comments
 (0)