Skip to content

fix: preserve media queries when applying HTML changes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: preserve media queries when applying HTML changes #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/code-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,18 +140,23 @@ export class CodeEditor {
this.previousHtmlCode = htmlCode;

let idStyles = '';

this.cssCodeEditor
.getContent()
.split('}\n')
.filter((el) => Boolean(el.trim()))
.map((cssObjectRule) => {
if (!(/}$/.test(cssObjectRule))) {
//* Have to check closing bracket existence for every rule cause it can be missed after split and add it if it doesnt match
if (/@media[^{]*{[^}]*#/.test(cssObjectRule)) {
// Media queries need double closing brackets
return `${cssObjectRule}}}`;
}
return `${cssObjectRule}}`;
}
})
.forEach(rule => {
if (/^#/.test(rule))
if (/^#|@media[^{]*{[^}]*#/.test(rule))
idStyles += rule;
});

Expand Down