fix: bump eslint-plugin-package-json to 0.85.0 (#2294)

## PR Checklist

- [x] Addresses an existing open issue: fixes #2271
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Finishes the work in #2288 and builds off the new ESLint `files`
extension structure in #2291.

Alas, due to
eslint-community/eslint-plugin-n#472,
`n/no-unpublished-bin` has to be manually disabled.

🎁

Author: JoshuaKGoldberg

eslint.config.js

@@ -72,6 +72,9 @@ export default defineConfig(
 			"no-useless-rename": "error",
 			"object-shorthand": "error",
 			"operator-assignment": "error",
+
+			// https://github.com/eslint-community/eslint-plugin-n/issues/472
+			"n/no-unpublished-bin": "off",
 		},
 		settings: { perfectionist: { partitionByComment: true, type: "natural" } },
 	},

package.json

@@ -15,7 +15,6 @@
 	"main": "lib/index.js",
 	"bin": "bin/index.js",
 	"files": [
-		"bin/index.js",
 		"lib/"
 	],
 	"scripts": {
@@ -94,7 +93,7 @@
 		"eslint-plugin-jsonc": "2.21.0",
 		"eslint-plugin-markdown": "5.1.0",
 		"eslint-plugin-n": "17.23.1",
-		"eslint-plugin-package-json": "0.54.0",
+		"eslint-plugin-package-json": "0.85.0",
 		"eslint-plugin-perfectionist": "4.15.1",
 		"eslint-plugin-regexp": "2.10.0",
 		"eslint-plugin-yml": "1.19.0",

pnpm-lock.yaml

@@ -27,6 +27,14 @@ describe("blockESLintNode", () => {
 			            "files": [
 			              "**/*.{js,ts}",
 			            ],
+			            "rules": [
+			              {
+			                "comment": "https://github.com/eslint-community/eslint-plugin-n/issues/472",
+			                "entries": {
+			                  "n/no-unpublished-bin": "off",
+			                },
+			              },
+			            ],
 			          },
 			          {
 			            "extends": [

src/blocks/blockESLintNode.test.ts

@@ -14,6 +14,15 @@ export const blockESLintNode = base.createBlock({
 						{
 							extends: ['n.configs["flat/recommended"]'],
 							files: [getScriptFileExtension(options)],
+							rules: [
+								{
+									comment:
+										"https://github.com/eslint-community/eslint-plugin-n/issues/472",
+									entries: {
+										"n/no-unpublished-bin": "off",
+									},
+								},
+							],
 						},
 						{
 							extends: ["tseslint.configs.disableTypeChecked"],

src/blocks/blockESLintNode.ts

@@ -247,7 +247,7 @@ describe("blockPackageJson", () => {
 		expect(creation).toMatchInlineSnapshot(`
 			{
 			  "files": {
-			    "package.json": "{"name":"test-repository","version":"0.0.0","description":"A very very very very very very very very very very very very very very very very long HTML-ish description ending with an emoji. 🧵","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"author":{"email":"npm@email.com"},"type":"module","bin":"bin/index.js","files":["bin/index.js"],"engines":{"node":">=20.12.0"}}",
+			    "package.json": "{"name":"test-repository","version":"0.0.0","description":"A very very very very very very very very very very very very very very very very long HTML-ish description ending with an emoji. 🧵","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"author":{"email":"npm@email.com"},"type":"module","bin":"bin/index.js","engines":{"node":">=20.12.0"}}",
 			  },
 			  "scripts": [
 			    {
@@ -275,7 +275,7 @@ describe("blockPackageJson", () => {
 		expect(creation).toMatchInlineSnapshot(`
 			{
 			  "files": {
-			    "package.json": "{"name":"test-repository","version":"0.0.0","description":"A very very very very very very very very very very very very very very very very long HTML-ish description ending with an emoji. 🧵","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"author":{"email":"npm@email.com"},"type":"module","bin":{"absolute":"bin/absolute.js","relative":"./bin/relative.js"},"files":["bin/absolute.js","bin/relative.js"],"engines":{"node":">=20.12.0"}}",
+			    "package.json": "{"name":"test-repository","version":"0.0.0","description":"A very very very very very very very very very very very very very very very very long HTML-ish description ending with an emoji. 🧵","repository":{"type":"git","url":"git+https://github.com/test-owner/test-repository.git"},"author":{"email":"npm@email.com"},"type":"module","bin":{"absolute":"bin/absolute.js","relative":"./bin/relative.js"},"engines":{"node":">=20.12.0"}}",
 			  },
 			  "scripts": [
 			    {

src/blocks/blockPackageJson.test.ts

@@ -59,10 +59,7 @@ export const blockPackageJson = base.createBlock({
 							...(options.pnpm && {
 								packageManager: `pnpm@${options.pnpm}`,
 							}),
-							files: processFiles([
-								...collectBinFiles(options.bin),
-								...(addons.properties.files ?? []),
-							]),
+							files: processFiles(addons.properties.files),
 							keywords: options.keywords,
 							name: options.repository,
 							repository: {
@@ -97,17 +94,12 @@ export const blockPackageJson = base.createBlock({
 	},
 });
 
-function collectBinFiles(bin: Record<string, string> | string | undefined) {
-	if (!bin) {
-		return [];
+function processFiles(files: string[] | undefined) {
+	// If no files have been specified, we can skip the property altogether
+	if (!files?.length) {
+		return undefined;
 	}
 
-	const files = typeof bin === "object" ? Object.values(bin) : [bin];
-
-	return files.map((file) => file.replace(/^\.\//, ""));
-}
-
-function processFiles(files: string[]) {
 	// First sort so that shorter entries are first (e.g. "lib/")...
 	const sortedByLength = files
 		.filter(Boolean)