integration test

Author: Joaopeuko

.github/workflows/test-metatrader5-integration.yml

@@ -1,4 +1,4 @@
-name: Test | Test MetaTrader5 Integration
+name: Test MetaTrader5 Integration
 
 on:
   push:
@@ -39,7 +39,7 @@ jobs:
           exit 1
         }
         
-        # Start MT5 in portable mode
+        # Start MT5 in portable mode and give it time to initialize
         $mtProcess = Start-Process -FilePath $mtPath -ArgumentList "/portable" -PassThru
         $processId = $mtProcess.Id
         Write-Host "Started MetaTrader 5 terminal with process ID: $processId"
@@ -50,38 +50,7 @@ jobs:
         python -m pip install --upgrade pip
         pip install MetaTrader5
 
-    - name: Test MetaTrader5 connection
+    - name: Test MetaTrader5 connection with improved script
       run: |
-        # Create a resilient test script
-        $script = @"
-        import MetaTrader5 as mt5
-        import time
-        import sys
-        
-        print(f"MetaTrader5 package version: {mt5.__version__}")
-        
-        # Try to connect with retries
-        max_attempts = 3
-        for attempt in range(max_attempts):
-            print(f"Connection attempt {attempt+1}/{max_attempts}...")
-            
-            if mt5.initialize():
-                print("MetaTrader5 initialized successfully")
-                mt5.shutdown()
-                sys.exit(0)
-            else:
-                error = mt5.last_error()
-                print(f"initialize() failed, error code = {error}")
-                if attempt < max_attempts - 1:
-                    time.sleep(5)
-        
-        # If we're still running, all attempts failed
-        # But we'll exit with success for CI purposes
-        print("Warning: Could not connect to MetaTrader5, but continuing...")
-        sys.exit(0)
-        "@
-        
-        # Save and run the script
-        $script | Out-File -FilePath "test_mt5_connection.py" -Encoding utf8
-        python test_mt5_connection.py
+        python tests/integration/test_mt5_connection.py
 

tests/integration/test_mt5_connection.py

@@ -1,7 +1,8 @@
 """Integration tests for MetaTrader 5 connection functionality."""
 
 import sys
-
+import os
+import time
 import MetaTrader5 as mt5
 
 
@@ -13,22 +14,44 @@ def test_mt5_connection() -> bool:
     """
     print(f"MetaTrader5 package version: {mt5.__version__}")
 
-    # Initialize MetaTrader 5
-    if not mt5.initialize():
-        print(f"initialize() failed, error code = {mt5.last_error()}")
-        sys.exit(1)
-
-    print(mt5.terminal_info())
-    print(f"MetaTrader5 terminal copyright: {mt5.terminal_info().copyright}")
-    print(f"MetaTrader5 terminal name: {mt5.terminal_info().name}")
-    print(f"MetaTrader5 terminal path: {mt5.terminal_info().path}")
-
-    authorized = mt5.login()
-    if authorized:
-        print(f"Connected to account: {mt5.account_info().login}")
-        print(f"Balance: {mt5.account_info().balance}")
-
+    # Define path to the MetaTrader terminal executable
+    path = "C:\\Program Files\\MetaTrader 5\\terminal64.exe"
+    print(f"MetaTrader5 path: {path}")
+
+    # Try to initialize with explicit path parameter
+    if not mt5.initialize(path=path):
+        error = mt5.last_error()
+        print(f"initialize() with path failed, error code = {error}")
+
+        # Try the second method: initialize with just a delay 
+        time.sleep(3)  # Give some time before retry
+        print("Retrying initialization...")
+        if not mt5.initialize():
+            error = mt5.last_error()
+            print(f"initialize() without path failed, error code = {error}")
+            sys.exit(1)
+
+    # Connection successful
+    print("MetaTrader5 initialized successfully")
+
+    # Get account info
+    account_info = mt5.account_info()
+    if account_info is not None:
+        print(f"Account info: server={account_info.server}, balance={account_info.balance}")
+    else:
+        print("Failed to get account info - this is normal without login credentials")
+
+    # Get terminal info
+    terminal_info = mt5.terminal_info()
+    if terminal_info is not None:
+        print(f"Terminal info: connected={terminal_info.connected}, path={terminal_info.path}")
+    else:
+        print("Failed to get terminal info")
+
+    # Shutdown the connection
+    print("Shutting down MetaTrader5 connection...")
     mt5.shutdown()
+    print("Done")
 
     print("Test completed successfully")
     return True