Skip to content

Commit f2cb977

Browse files
committed
修改版本逻辑校验错误的问题
1 parent ae60e4a commit f2cb977

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

src/JiuLing.CommonLibs.UnitTests/VersionUtilsTests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public void CheckNeedUpdate2Test(string currentVersion, string newVersion, bool
3232
}
3333

3434
[TestMethod()]
35-
[DataRow("1.0.0", "1.0.2", "1.0.0", false, true)]
35+
[DataRow("1.0.0", "1.0.2", "1.0.0", true, true)]
3636
[DataRow("1.0.0", "1.0.2", "1.0.1", true, false)]
3737
[DataRow("1.0.0", "1.0.0", "1.0.0", false, true)]
3838
public void CheckNeedUpdate3Test(string currentVersion, string newVersion, string minVersion, bool isNeedUpdate, bool isAllowUse)
@@ -45,11 +45,11 @@ public void CheckNeedUpdate3Test(string currentVersion, string newVersion, strin
4545
}
4646

4747
[TestMethod()]
48-
[DataRow("1.0.0", "1.0.2", "1.0.0", false, true)]
48+
[DataRow("1.0.0", "1.0.2", "1.0.0", true, true)]
4949
[DataRow("1.0.0", "1.0.2", "1.0.1", true, false)]
5050
[DataRow("1.0.0", "1.0.0", "1.0.0", false, true)]
5151
[DataRow("1.0.0", "1.0.0.0", "1.0.0", false, true)]
52-
[DataRow("1.1.0", "1.2.0.0", "1.1.0.0", false, true)]
52+
[DataRow("1.1.0", "1.2.0.0", "1.1.0.0", true, true)]
5353
[DataRow("1.0.0", "1.2.0.0", "1.1.0.0", true, false)]
5454
public void CheckNeedUpdate4Test(string currentVersion, string newVersion, string minVersion, bool isNeedUpdate, bool isAllowUse)
5555
{

src/JiuLing.CommonLibs/JiuLing.CommonLibs.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<PackageProjectUrl>https://github.com/JiuLing-zhang/JiuLing.CommonLibs</PackageProjectUrl>
88
<PackageIcon>nuget_icon.png</PackageIcon>
99
<PackageIconUrl />
10-
<Version>1.6.5</Version>
10+
<Version>1.6.6</Version>
1111
<GenerateDocumentationFile>true</GenerateDocumentationFile>
1212
<PackageReadmeFile>README.md</PackageReadmeFile>
1313
<Copyright>Copyright (c) 2021 九零</Copyright>

src/JiuLing.CommonLibs/VersionUtils.cs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,20 @@ public static (bool IsNeedUpdate, bool IsAllowUse) CheckNeedUpdate(string curren
7474
/// <returns>返回(是否需要自动更新,当前版本是否允许使用)</returns>
7575
public static (bool IsNeedUpdate, bool IsAllowUse) CheckNeedUpdate(Version currentVersion, Version newVersion, Version minVersion)
7676
{
77-
if (!CheckNeedUpdate(currentVersion, newVersion))
77+
bool isNeedUpdate = CheckNeedUpdate(currentVersion, newVersion);
78+
int result = currentVersion.CompareTo(minVersion);
79+
if (result < 0)
7880
{
79-
return (false, true);
81+
return (isNeedUpdate, false);
8082
}
81-
82-
if (currentVersion.CompareTo(minVersion) < 0)
83+
else if (result == 0)
8384
{
84-
return (true, false);
85+
return (isNeedUpdate, true);
86+
}
87+
else
88+
{
89+
return (isNeedUpdate, true);
8590
}
86-
87-
return (false, true);
8891
}
8992
}
9093
}

0 commit comments

Comments
 (0)