Skip to content

Commit 5a7a5da

Browse files
committed
Remove unnecessary logging.
1 parent 98ba066 commit 5a7a5da

File tree

2 files changed

+12
-8
lines changed
  • lets-plot-compose/src

2 files changed

+12
-8
lines changed

lets-plot-compose/src/androidMain/kotlin/org/jetbrains/letsPlot/skia/compose/PlotPanelRaw.kt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,15 @@ import androidx.compose.ui.Modifier
1010
import androidx.compose.ui.text.TextStyle
1111
import androidx.compose.ui.viewinterop.AndroidView
1212
import org.jetbrains.letsPlot.android.canvas.CanvasView
13+
import org.jetbrains.letsPlot.commons.logging.PortableLogging
1314
import org.jetbrains.letsPlot.core.util.sizing.SizingPolicy
1415
import org.jetbrains.letsPlot.raster.builder.MonolithicCanvas
1516
import org.jetbrains.letsPlot.raster.view.PlotCanvasFigure
16-
import org.jetbrains.letsPlot.skia.compose.util.NaiveLogger
1717

18-
private val LOG = NaiveLogger("PlotPanel")
18+
//import org.jetbrains.letsPlot.skia.compose.util.NaiveLogger
19+
20+
//private val LOG = NaiveLogger("PlotPanel")
21+
private val LOG = PortableLogging.logger(name = "[PlotPanelRaw]")
1922

2023
@Suppress("FunctionName")
2124
@Composable
@@ -29,11 +32,11 @@ actual fun PlotPanelRaw(
2932
) {
3033
var plotCanvasFigure by remember { mutableStateOf(PlotCanvasFigure()) }
3134

32-
LOG.print { "Recompose PlotPanel()" }
35+
// LOG.info { "Recompose PlotPanel()" }
3336

3437
AndroidView(
3538
factory = { ctx ->
36-
LOG.print { "PlotPanel: AndroidView factory called" }
39+
// LOG.info { "PlotPanel: AndroidView factory called" }
3740
val canvasView = CanvasView(ctx)
3841
canvasView.figure = plotCanvasFigure
3942
canvasView

lets-plot-compose/src/desktopMain/kotlin/org/jetbrains/letsPlot/skia/compose/PlotPanelRaw.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import androidx.compose.ui.layout.onSizeChanged
1818
import androidx.compose.ui.platform.LocalDensity
1919
import androidx.compose.ui.text.TextStyle
2020
import org.jetbrains.letsPlot.commons.geometry.DoubleVector
21+
import org.jetbrains.letsPlot.commons.logging.PortableLogging
2122
import org.jetbrains.letsPlot.core.plot.builder.interact.tools.FigureModelHelper
2223
import org.jetbrains.letsPlot.core.spec.Option.Meta.Kind.GG_TOOLBAR
2324
import org.jetbrains.letsPlot.core.spec.config.PlotConfig
@@ -28,9 +29,11 @@ import org.jetbrains.letsPlot.core.util.sizing.SizingPolicy
2829
import org.jetbrains.letsPlot.skia.builderLW.MonolithicSkiaLW
2930
import org.jetbrains.letsPlot.skia.compose.desktop.PlotContainer
3031
import org.jetbrains.letsPlot.skia.compose.desktop.SvgViewPanel
31-
import org.jetbrains.letsPlot.skia.compose.util.NaiveLogger
3232

33-
private val LOG = NaiveLogger("PlotPanel")
33+
//import org.jetbrains.letsPlot.skia.compose.util.NaiveLogger
34+
35+
//private val LOG = NaiveLogger("PlotPanel")
36+
private val LOG = PortableLogging.logger(name = "[PlotPanelRaw]")
3437

3538
@Suppress("FunctionName")
3639
@Composable
@@ -112,8 +115,6 @@ actual fun PlotPanelRaw(
112115
// Render the plot
113116
LaunchedEffect(panelSize, processedPlotSpec, specOverrideList) {
114117
if (panelSize != DoubleVector.ZERO) {
115-
LOG.print("Plot update triggered")
116-
117118
val plotSpec =
118119
SpecOverrideUtil.applySpecOverride(processedPlotSpec, specOverrideList).toMutableMap()
119120

0 commit comments

Comments
 (0)