Skip to content

Commit 3e7aef6

Browse files
committed
[broker-7] rework according new rlib features
1 parent d0af0b3 commit 3e7aef6

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/main/java/com/ss/mqtt/broker/service/impl/AbstractCredentialSource.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.ss.mqtt.broker.service.CredentialSource;
44
import com.ss.rlib.common.util.dictionary.ConcurrentObjectDictionary;
55
import com.ss.rlib.common.util.dictionary.Dictionary;
6-
import com.ss.rlib.common.util.dictionary.DictionaryFactory;
76
import com.ss.rlib.common.util.dictionary.ObjectDictionary;
87
import org.jetbrains.annotations.NotNull;
98
import reactor.core.publisher.Mono;
@@ -13,7 +12,7 @@
1312
public abstract class AbstractCredentialSource implements CredentialSource {
1413

1514
private final ConcurrentObjectDictionary<String, byte[]> credentials =
16-
DictionaryFactory.newConcurrentStampedLockObjectDictionary();
15+
ConcurrentObjectDictionary.ofType(String.class, byte[].class);
1716

1817
abstract void init();
1918

src/main/java/com/ss/mqtt/broker/service/impl/SimpleSubscriptions.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.ss.rlib.common.util.array.Array;
1111
import com.ss.rlib.common.util.array.ConcurrentArray;
1212
import com.ss.rlib.common.util.dictionary.ConcurrentObjectDictionary;
13-
import com.ss.rlib.common.util.dictionary.DictionaryFactory;
1413
import com.ss.rlib.common.util.dictionary.ObjectDictionary;
1514
import org.jetbrains.annotations.NotNull;
1615

@@ -23,7 +22,7 @@ public class SimpleSubscriptions implements Subscriptions {
2322
ConcurrentArray.supplier(Subscriber.class);
2423

2524
private final @NotNull ConcurrentObjectDictionary<String, ConcurrentArray<Subscriber>> subscriptions =
26-
DictionaryFactory.newConcurrentStampedLockObjectDictionary();
25+
ConcurrentObjectDictionary.ofType(String.class, ConcurrentArray.class);
2726

2827
public @NotNull Array<Subscriber> getSubscribers(@NotNull String topicName) {
2928

@@ -66,10 +65,9 @@ public class SimpleSubscriptions implements Subscriptions {
6665
if (subscribers == null) {
6766
return UnsubscribeAckReasonCode.NO_SUBSCRIPTION_EXISTED;
6867
} else {
69-
//noinspection ConstantConditions
70-
boolean removed = subscribers.getInWriteLock(
68+
boolean removed = subscribers.removeIfInWriteLock(
7169
mqttClient,
72-
(subs, client) -> subs.removeIf(subscriber -> client.equals(subscriber.getMqttClient()))
70+
(client, subscriber) -> client.equals(subscriber.getMqttClient())
7371
);
7472

7573
return removed ? UnsubscribeAckReasonCode.SUCCESS : UnsubscribeAckReasonCode.NO_SUBSCRIPTION_EXISTED;

0 commit comments

Comments
 (0)