Minor cleanup and uncomment release steps in publish pipeline

Author: Jameak

.github/workflows/publish.yml

@@ -44,11 +44,11 @@ jobs:
         with:
           name: release-pack-nupkg
           path: artifacts
-      #- name: Run nuget package validation
-      #  run: |
-      #    foreach($file in (Get-ChildItem "./artifacts/" -Recurse -Include *.nupkg)) {
-      #        dotnet meziantou.validate-nuget-package $file
-      #    }
+      - name: Run nuget package validation
+        run: |
+          foreach($file in (Get-ChildItem "./artifacts/" -Recurse -Include *.nupkg)) {
+              dotnet meziantou.validate-nuget-package $file
+          }
       
   publish-to-nuget-and-gh-release:
     # Publish only when creating a github release
@@ -72,11 +72,11 @@ jobs:
         id: login
         with:
           user: ${{ secrets.NUGET_USER }}
-      #- name: Upload nupkg to nuget
-      #  run: |
-      #    foreach($file in (Get-ChildItem "./artifacts/" -Recurse -Include *.nupkg)) {
-      #        dotnet nuget push $file --api-key "${{ steps.login.outputs.NUGET_API_KEY }}" --source https://api.nuget.org/v3/index.json --skip-duplicate
-      #    }
+      - name: Upload nupkg to nuget
+        run: |
+          foreach($file in (Get-ChildItem "./artifacts/" -Recurse -Include *.nupkg)) {
+              dotnet nuget push $file --api-key "${{ steps.login.outputs.NUGET_API_KEY }}" --source https://api.nuget.org/v3/index.json --skip-duplicate
+          }
       - name: Upload nupkg to github release
         run: |
           foreach($file in (Get-ChildItem "./artifacts/" -Recurse -Include *.nupkg)) {

README.md

@@ -68,7 +68,7 @@ var firstPage = KeySetPaginator.ApplyPagination(
 
 For Offset pagination, use `OffsetPaginator` instead.
 
-### Retrieving the cursor pointing to the next page
+### Retrieving the cursor pointing to the next page as an opaque string
 Each returned page-object includes a helper that exposes the cursor used to retrieve the next page.
 
 #### KeySet pagination

src/Jameak.CursorPagination.SourceGenerator/Jameak.CursorPagination.SourceGenerator.csproj

@@ -23,7 +23,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" PrivateAssets="all"/>
   </ItemGroup>
 
   <ItemGroup>

test/Jameak.CursorPagination.SourceGenerator.IntegrationTests/KeySetCursorSerializationTests.cs

@@ -1,4 +1,4 @@
-using CsCheck;
+using CsCheck;
 using Jameak.CursorPagination.SourceGenerator.IntegrationTests.InputClasses;
 using Jameak.CursorPagination.SourceGenerator.IntegrationTests.PartialStrategies;
 
@@ -24,7 +24,7 @@ public void VerifyCursorSerializationManyTypes()
             LongProp = -7,
             SbyteProp = 8,
             ShortProp = 9,
-            StringProp = "abc",
+            StringProp = "abc😊",
             UintProp = 10,
             UlongProp = 11,
             UshortProp = 12,
@@ -38,7 +38,7 @@ public void VerifyCursorSerializationManyTypes()
         var deserializedCursor = strategy.CursorFromString(cursorString);
 
         // Assert
-        Assert.Equal("eyIwIjpmYWxzZSwiMSI6MiwiMiI6IjYzODcxMzgzODQ1MDA2MDAwMDpVVEMiLCIzIjoiMjAyNC0wMS0wMlQwMzowNDowNS4wMDYrMDA6MDAiLCI0IjozLCI1Ijo0LjEsIjYiOjUuMiwiNyI6ImFhYWFhYWFhLWFhYWEtYWFhYS1hYWFhLWFhYWFhYWFhYWFhYSIsIjgiOi02LCI5IjotNywiMTAiOjgsIjExIjo5LCIxMiI6ImFiYyIsIjEzIjoxMiwiMTQiOjEwLCIxNSI6MTEsIjE2IjpudWxsfQ",
+        Assert.Equal("eyIwIjpmYWxzZSwiMSI6MiwiMiI6IjYzODcxMzgzODQ1MDA2MDAwMDpVVEMiLCIzIjoiMjAyNC0wMS0wMlQwMzowNDowNS4wMDYrMDA6MDAiLCI0IjozLCI1Ijo0LjEsIjYiOjUuMiwiNyI6ImFhYWFhYWFhLWFhYWEtYWFhYS1hYWFhLWFhYWFhYWFhYWFhYSIsIjgiOi02LCI5IjotNywiMTAiOjgsIjExIjo5LCIxMiI6ImFiY1x1RDgzRFx1REUwQSIsIjEzIjoxMiwiMTQiOjEwLCIxNSI6MTEsIjE2IjpudWxsfQ",
             cursorString);
         Assert.Equal(cursor, deserializedCursor);
     }