Skip to content
Draft
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
d29ab3b
Added initial work to get basic image covers working properly
bblhd Oct 16, 2025
7b33850
Merge branch 'JabRef:main' into feature/book-front-cover-10120
bblhd Oct 16, 2025
05d21d4
Merge branch 'main' of https://github.com/JabRef/jabref into feature/…
bblhd Oct 18, 2025
2865553
fixed order of cover images, refactored some of the cover code
bblhd Oct 18, 2025
7842c6e
rudimentary cover fetching
bblhd Nov 12, 2025
3f91954
changed tabs to spaces
bblhd Nov 12, 2025
bb58664
merged with upstream
bblhd Nov 12, 2025
112a095
fixed problems and changed cover tag parenthesis for display
bblhd Nov 12, 2025
56475f3
fixed small issues, re-re-factoring
bblhd Nov 15, 2025
68e55c6
incorrect name, now getCoverImageFileFromStringOfISBN
bblhd Nov 15, 2025
a9e8120
merged with upstream
bblhd Nov 15, 2025
71fba83
fixed pattern naming somewhat, improved handling of edge cases and ad…
bblhd Nov 16, 2025
0d97ac5
Added preferences for cover images
bblhd Nov 16, 2025
25b996c
merge from upstream
bblhd Nov 16, 2025
f4946cd
Merge branch 'main' into feature/book-front-cover-10120
Siedlerchr Nov 17, 2025
2c61ef3
Fix submodule changes
bblhd Nov 17, 2025
dc614c4
style changes
bblhd Nov 17, 2025
5e9b8af
fixes to getSuggestedFileName and added localization for new text
bblhd Nov 17, 2025
2d9abbc
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 17, 2025
b56b664
fixed problem in getSuggestedFileName
bblhd Nov 17, 2025
45ff913
further fixes
bblhd Nov 17, 2025
4f6a3b6
fixed missing period in suggested filename
bblhd Nov 17, 2025
8b05127
fixed bad LinkedList initializer in test and missed whitespace
bblhd Nov 17, 2025
9d705fc
brought behaviour of getSuggestedFileName(extension) in line with get…
bblhd Nov 17, 2025
73831aa
fixed errors in test
bblhd Nov 17, 2025
d7a6537
removed unused import
bblhd Nov 17, 2025
692db5f
fixed test cases and some rewrite checks
bblhd Nov 17, 2025
23f3203
fixed test name collision
bblhd Nov 17, 2025
c5d7d7e
reversed my misunderstanding of org.openrewrite.java.migrate.util.Opt…
bblhd Nov 17, 2025
e5df521
added pull request to changelog, added tests for getFileNameFromUrl, …
bblhd Nov 17, 2025
b3473b0
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 17, 2025
77398d8
removed wrong arguments from test
bblhd Nov 17, 2025
ca5dcb2
removed wrong arguments from test
bblhd Nov 17, 2025
cd33ce2
improved behaviour of BookCoverFetcher when no directory available
bblhd Nov 18, 2025
df05e83
fix for changed argument order
bblhd Nov 18, 2025
a41f391
filled catch block
bblhd Nov 18, 2025
9ef2bb4
changed uses of path.tofile().method() to Files.method(path) where po…
bblhd Nov 20, 2025
cbb3340
added mime type detection for existing book covers
bblhd Nov 20, 2025
4124d98
fixed import order
bblhd Nov 20, 2025
4f6607f
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 20, 2025
99fe001
missing semicolon
bblhd Nov 20, 2025
777ad41
fixed new variable and removed superfluous check
bblhd Nov 20, 2025
9fc23be
missing argument somehow
bblhd Nov 20, 2025
966fd67
Update jabgui/src/main/java/org/jabref/gui/importer/BookCoverFetcher.…
bblhd Nov 20, 2025
c68ef91
initial rework of covers, away from using attached files
bblhd Nov 20, 2025
bc9f0b4
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 20, 2025
622838b
replaced findFileByNameWithAnyExtension with simpler code that is eas…
bblhd Nov 20, 2025
ca67eb3
removed LinkedFile#getURI/getURL due to lack of use
bblhd Nov 20, 2025
3ebdc55
improved test sources
bblhd Nov 20, 2025
f2d7a1a
fixed test formating
bblhd Nov 20, 2025
7f17cd9
fixed name of getValidFileName
bblhd Nov 20, 2025
477d845
fixed missing .get() for Optional
bblhd Nov 20, 2025
6824940
fixed missing import
bblhd Nov 20, 2025
b0be871
fixed things missed in book cover changes
bblhd Nov 20, 2025
609371a
better use of map
bblhd Nov 20, 2025
5813bcc
fixed syntax
bblhd Nov 20, 2025
11b3570
corrected bad definition and removed createFileNameFromPattern "defau…
bblhd Nov 20, 2025
fb1deab
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 20, 2025
2cb5c99
minor BookCoverFetcher fixes
bblhd Nov 20, 2025
05d3561
more usage of map, implemented basic seperation of cover images from …
bblhd Nov 26, 2025
ef72987
Merge branch 'main' into feature/book-front-cover-10120
bblhd Nov 26, 2025
8b87815
fixed mangled merge
bblhd Nov 26, 2025
d642f6c
fixed test using Argument.of rather than Arguments.of
bblhd Nov 26, 2025
0d474a3
more Arguments fix, removed unused imports, other syntax fixes
bblhd Nov 26, 2025
8f39853
fixes for wrong import and made getFileNameFromUrl return Optional, p…
bblhd Nov 26, 2025
3d9b17f
fixed missing character when parsing urls, removed bad test case
bblhd Nov 26, 2025
f521265
Better use of optionals, fixed test case errors
bblhd Dec 7, 2025
de4f560
Merge branch 'main' into feature/book-front-cover-10120
bblhd Dec 7, 2025
64c14f5
fixed type in test case
bblhd Dec 7, 2025
8edad2a
fixed extra comma in test case
bblhd Dec 7, 2025
6fe72a7
realigned CsvSource
bblhd Dec 7, 2025
df8c706
realigned CsvSource even more
bblhd Dec 7, 2025
e55ed6a
fixed that suggestedFileNames were assumed Optional in test, and runa…
bblhd Dec 7, 2025
d1c07cb
actually did that
bblhd Dec 7, 2025
389b731
missing parenthesis
bblhd Dec 7, 2025
ea2ecde
unwanted spaces
bblhd Dec 7, 2025
65d61be
re-added a getSuggestedFileName, used capitals for constant
bblhd Dec 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public Optional<Path> getDownloadedCoverForEntry(BibEntry entry, Path directory)
public void downloadCoversForEntry(BibEntry entry, Path directory) {
Optional<ISBN> isbn = entry.getISBN();
if (isbn.isPresent()) {
final String name = "isbn-" + isbn.asString();
final String name = "isbn-" + isbn.get().asString();
if (findExistingImage(name, directory).isEmpty()) {
final String url = getSourceForIsbn(isbn);
final String url = getSourceForIsbn(isbn.get());
Optional<LinkedFile> file = downloadCoverImage(url, name, directory);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please get used to .map for optionals. At the end, you can do forEach as you don't need the resulting downloaded file at this place.

}
Expand Down
Loading