Skip to content

Conversation

@agustinmista
Copy link
Contributor

@agustinmista agustinmista commented Nov 26, 2025

This PR brings in cardano-base and propagates a set of CardanoFeatureFlags from the top-level RunNodeArgs down to the NodeKernelArgs.

This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the PerasFlag feature flag (e.g, spawning voting and object diffusion threads, deciding when a node can consider itself as CaughtUp, etc.).

@agustinmista
Copy link
Contributor Author

agustinmista commented Nov 26, 2025

Please note that ⚠️this is a breaking change⚠️ for any client invoking run or runWith, as it will be lacking the mandatory rnFeatureFlags field.

To provide some confidence about the future integration into cardano-node, I trivially backported the changes into releases/ouroboros-consensus-0.28.0.0 and integrated them into cardano-node@10.6.1, see CI run here.

Brings in cardano-base and propagates a set of `CardanoFeatureFlag`s
from the top-level `RunNodeArgs` down to the `NodeKernelArgs`.

This is currently needed by upcoming PRs that need to conditionally
enable certain behavior based on the `PerasFlag` feature flag.
@agustinmista agustinmista force-pushed the peras/main-pr/introduce-feature-flags branch from 8878cb1 to 32dbee3 Compare December 2, 2025 09:48
@agustinmista agustinmista marked this pull request as ready for review December 2, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants