Skip to content

Commit 29c6650

Browse files
jutaromgmeier
authored andcommitted
trace-dispatcher, trace-forward: Reverse dependencies
Fixes for tests and imports Cabal versions
1 parent 425b8c1 commit 29c6650

File tree

25 files changed

+120
-166
lines changed

25 files changed

+120
-166
lines changed

bench/tx-generator/src/Cardano/Benchmarking/Tracer.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ import qualified Data.Text as Text
4949
import Data.Time.Clock
5050
import GHC.Generics
5151

52-
import Trace.Forward.Utils.DataPoint
5352
import Trace.Forward.Utils.TraceObject
53+
import Trace.Forward.Forwarding (initForwardingDelayed)
5454

5555
pattern TracerNameBench :: Text
5656
pattern TracerNameBench = "Benchmark"
@@ -121,7 +121,7 @@ initTxGenTracers mbForwarding = do
121121
prepareForwardingTracer = forM mbForwarding $
122122
\(iomgr, networkId, tracerSocket) -> do
123123
let forwardingConf = fromMaybe defaultForwarder (tcForwarder initialTraceConfig)
124-
(forwardSink :: ForwardSink TraceObject, dpStore, kickoffForwarder) <-
124+
(forwardSink, dpStore, kickoffForwarder) <-
125125
initForwardingDelayed iomgr forwardingConf (toNetworkMagic networkId) Nothing $ Just (Net.LocalPipe tracerSocket, Initiator)
126126

127127
-- we need to provide NodeInfo DataPoint, to forward generator's name
@@ -134,7 +134,7 @@ initTxGenTracers mbForwarding = do
134134
traceWith nodeInfoTracer genInfo
135135

136136
kickoffForwarder
137-
pure $ forwardTracer forwardSink
137+
pure $ forwardTracer (writeToSink forwardSink)
138138

139139
prepareGenInfo :: IO NodeInfo
140140
prepareGenInfo =

cardano-node/cardano-node.cabal

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,8 +211,8 @@ library
211211
, sop-extras
212212
, text >= 2.0
213213
, time
214-
, trace-dispatcher ^>= 2.9.2
215-
, trace-forward ^>= 2.2.11
214+
, trace-dispatcher ^>= 2.10.0
215+
, trace-forward ^>= 2.3.0
216216
, trace-resources ^>= 0.2.3
217217
, tracer-transformers
218218
, transformers

cardano-node/src/Cardano/Node/Tracing/API.hs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ import Data.Time.Clock (getCurrentTime)
5151
import Network.Mux.Trace (TraceLabelPeer (..))
5252
import Network.Socket (HostName)
5353
import System.Metrics as EKG
54+
import Trace.Forward.Forwarding (initForwardingDelayed)
55+
import Trace.Forward.Utils.TraceObject (writeToSink)
5456

5557

5658
initTraceDispatcher ::
@@ -137,7 +139,7 @@ initTraceDispatcher nc p networkMagic nodeKernel p2pMode noBlockForging = do
137139
forwardingConf :: TraceOptionForwarder
138140
forwardingConf = fromMaybe defaultForwarder (tcForwarder trConfig)
139141
initForwardingDelayed iomgr forwardingConf networkMagic (Just ekgStore) tracerSocketMode
140-
pure (forwardTracer forwardSink, dataPointTracer dpStore, kickoffForwarder)
142+
pure (forwardTracer (writeToSink forwardSink), dataPointTracer dpStore, kickoffForwarder)
141143
else
142144
-- Since 'Forwarder' backend isn't enabled, there is no forwarding.
143145
-- So we use nullTracers to ignore 'TraceObject's and 'DataPoint's.

cardano-node/src/Cardano/Node/Tracing/Tracers.hs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,6 @@ import Data.Proxy (Proxy (..))
7373
import Network.Mux.Trace (TraceLabelPeer (..))
7474
import Network.Socket (SockAddr)
7575

76-
import Trace.Forward.Utils.DataPoint (DataPoint)
77-
7876
-- | Construct tracers for all system components.
7977
--
8078
mkDispatchTracers

cardano-tracer/cardano-tracer.cabal

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ library
197197
, string-qq
198198
, text
199199
, time
200-
, trace-dispatcher ^>= 2.9.2
201-
, trace-forward ^>= 2.2.11
200+
, trace-dispatcher ^>= 2.10.0
201+
, trace-forward ^>= 2.3.0
202202
, trace-resources ^>= 0.2.3
203203
, wai ^>= 3.2
204204
, warp ^>= 3.4

cardano-tracer/src/Cardano/Tracer/Handlers/ReForwarder.hs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module Cardano.Tracer.Handlers.ReForwarder
1515
( initReForwarder
1616
) where
1717

18-
import Cardano.Logging.Forwarding
18+
import Trace.Forward.Forwarding
1919
import Cardano.Logging.Trace
2020
import Cardano.Logging.Tracer.DataPoint
2121
import qualified Cardano.Logging.Types as Log
@@ -29,8 +29,8 @@ import Control.Monad (when)
2929
import Data.List (isPrefixOf)
3030
import qualified Data.Text as Text
3131

32-
import Trace.Forward.Utils.DataPoint
33-
import Trace.Forward.Utils.TraceObject (ForwardSink, writeToSink)
32+
import Trace.Forward.Utils.TraceObject (writeToSink)
33+
import Trace.Forward.Utils.ForwardSink (ForwardSink)
3434

3535
-- | Initialize the reforwarding service if configured to be active.
3636
-- Returns

cardano-tracer/test/Cardano/Tracer/Test/Forwarder.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ import Trace.Forward.Run.DataPoint.Forwarder
7171
import Trace.Forward.Run.TraceObject.Forwarder
7272
import Trace.Forward.Utils.DataPoint
7373
import Trace.Forward.Utils.TraceObject
74+
import Trace.Forward.Utils.ForwardSink (ForwardSink)
7475

7576
data ForwardersMode = Initiator | Responder
7677

cardano-tracer/test/cardano-tracer-test-ext.hs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ import qualified System.Process as Sys
2929

3030
import Test.Tasty
3131
import Test.Tasty.QuickCheck
32+
import Trace.Forward.Forwarding (initForwarding)
33+
import Trace.Forward.Utils.TraceObject (writeToSink)
3234

3335
main :: IO ()
3436
main = do
@@ -137,4 +139,4 @@ getExternalTracerState TestSetup{..} ref = do
137139
let tracerSocketMode = Just (Net.LocalPipe (unI tsSockExternal), Initiator)
138140
forwardingConf = fromMaybe defaultForwarder (tcForwarder simpleTestConfig)
139141
initForwarding iomgr forwardingConf (unI tsNetworkMagic) Nothing tracerSocketMode
140-
pure (externalTracerHdl, forwardTracer forwardSink)
142+
pure (externalTracerHdl, forwardTracer (writeToSink forwardSink))

trace-dispatcher/src/Cardano/Logging.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import Cardano.Logging.ConfigurationParser as X
77
import Cardano.Logging.Consistency as X
88
import Cardano.Logging.DocuGenerator as X
99
import Cardano.Logging.Formatter as X
10-
import Cardano.Logging.Forwarding as X
1110
import Cardano.Logging.FrequencyLimiter as X
1211
import Cardano.Logging.Trace as X
1312
import Cardano.Logging.TraceDispatcherMessage as X

trace-dispatcher/src/Cardano/Logging/DocuGenerator.hs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ import Data.Text.Internal.Builder (toLazyText)
4848
import Data.Text.Lazy (toStrict)
4949
import Data.Text.Lazy.Builder (Builder, fromString, fromText, singleton)
5050

51-
import Trace.Forward.Utils.DataPoint (DataPoint (..))
52-
5351
type InconsistencyWarning = Text
5452

5553
utf16CircledT :: Text
@@ -331,7 +329,7 @@ docTracer backendConfig = Trace $ TR.arrow $ TR.emit output
331329

332330
docTracerDatapoint :: MonadIO m =>
333331
BackendConfig
334-
-> Trace m DataPoint
332+
-> Trace m a
335333
docTracerDatapoint backendConfig = Trace $ TR.arrow $ TR.emit output
336334
where
337335
output p@(_, Left TCDocument {}) =

0 commit comments

Comments
 (0)