-
Notifications
You must be signed in to change notification settings - Fork 31
result_type to raise unless at least one argument is usm_ndarray #1876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@oleksandr-pavlyk In theory, this should mean only dtypes is acceptable. Of course we have device-specific concerns, but, perhaps we should assume the full dtype matrix if no array is specified? |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_147 ran successfully. |
…ndarray Implementation of dpt.where was calling `dpt.result_type` with just dtypes, although it has the device available. Implementation of result_type was factored out into a helper function which can accommodate know device, and reused by `dpt.result_type` and `_where_result_type` function. Test files were tweaked to avoid calling `dpt.result_type` with just dtypes.
94d8624 to
5afce63
Compare
vtavana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, a few dpnp tests fail. I am working on updating dpnp accordingly.
Fixed exception message wording Co-authored-by: vtavana <120411540+vtavana@users.noreply.github.com>
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_147 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_148 ran successfully. |
|
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_149 ran successfully. |
New array API test failure introduced also seems to be a result of this problem. |
|
Yes, this change goes against array API spec. Closing without merging. |
dpt.result_typeis being changed to raise unless at least one argument isdpt.usm_ndarray.Implementation of
dpt.wherewas callingdpt.result_typewith just dtypes, although it has the device available. Implementation ofresult_typewas factored out into a helper function which can accommodate know device, and reused bydpt.result_typeand_where_result_typefunction.Test files were tweaked to avoid calling
dpt.result_typewith just dtypes.Closes gh-1874 and supersedes gh-1875