#422765 - Fixed sonar issues

Author: ppelgmv

src/app/app.component.scss

@@ -6,8 +6,7 @@ import {AppConfigService} from "./app-config.service";
 
 @Component({
   selector: 'app-root',
-  templateUrl: './app.component.html',
-  styleUrls: ['./app.component.scss']
+  templateUrl: './app.component.html'
 })
 export class AppComponent implements OnInit {
 

src/app/app.component.ts

@@ -15,13 +15,12 @@ import {MAT_FORM_FIELD_DEFAULT_OPTIONS} from '@angular/material/form-field';
 import {AppConfigService} from "./app-config.service";
 import {MatSnackBarModule} from "@angular/material/snack-bar";
 import {CONNECTOR_CATALOG_API, CONNECTOR_MANAGEMENT_API, DATA_ADDRESS_TYPES} from "./shared/utils/app.constants";
-import {HTTP_INTERCEPTORS} from "@angular/common/http";
+import {HTTP_INTERCEPTORS, HttpClientModule} from "@angular/common/http";
 import {EdcApiKeyInterceptor} from "./shared/interceptors/apikey.interceptor";
 import {environment} from "../environments/environment";
 import { EdcConnectorClient } from "@think-it-labs/edc-connector-client";
 import {MatCardModule} from '@angular/material/card';
 import {SharedModule} from './shared/shared.module';
-import { HttpClientModule } from '@angular/common/http';
 
 @NgModule({
   imports: [
@@ -72,7 +71,6 @@ import { HttpClientModule } from '@angular/common/http';
     {
       provide: HTTP_INTERCEPTORS, multi: true, useFactory: () => {
         let i = new EdcApiKeyInterceptor();
-        // TODO: read this from app.config.json??
         i.apiKey = environment.apiKey
         return i;
       }, deps: [AppConfigService]

src/app/app.module.ts

@@ -21,6 +21,4 @@
         <mat-icon>cancel</mat-icon> Cancel
     </button>
 </div>
-<!-- <mat-progress-bar mode="indeterminate" color="accent"></mat-progress-bar> -->
-
 </mat-dialog-actions>

src/app/pages/contracts/catalog-browser-transfer-dialog/catalog-browser-transfer-dialog.component.html

@@ -1,15 +1,9 @@
-import {Component, Inject, OnInit} from '@angular/core';
-import {AssetService} from "../../../shared/services/asset.service";
+import {Component, OnInit} from '@angular/core';
 import {ContractAgreementService} from "../../../shared/services/contractAgreement.service";
-import {TransferProcessService} from "../../../shared/services/transferProcess.service";
 import {from, Observable, of} from "rxjs";
-import { Asset, ContractAgreement, TransferProcessInput, IdResponse } from "../../../shared/models/edc-connector-entities";
-import {ContractOffer} from "../../../shared/models/contract-offer";
-import {filter, first, map, switchMap, tap} from "rxjs/operators";
+import { ContractAgreement, IdResponse } from "../../../shared/models/edc-connector-entities";
+import {filter, map, switchMap, tap} from "rxjs/operators";
 import {NotificationService} from"../../../shared/services/notification.service";
-import {
-  CatalogBrowserTransferDialog
-} from "../catalog-browser-transfer-dialog/catalog-browser-transfer-dialog.component";
 import {MatDialog} from "@angular/material/dialog";
 import {CatalogBrowserService} from "../../../shared/services/catalog-browser.service";
 import {Router} from "@angular/router";
@@ -83,7 +77,7 @@ export class ContractViewerComponent implements OnInit {
   private startPolling(transferProcessId: IdResponse, contractId: string) {
     // track this transfer process
     this.runningTransfers.push({
-      processId: transferProcessId.id!,
+      processId: transferProcessId.id,
       state: TransferProcessStates.REQUESTED,
       contractId: contractId
     });

src/app/pages/contracts/contract-viewer/contract-viewer.component.ts

@@ -8,8 +8,7 @@ export interface DialogData {
 
 @Component({
   selector: 'policy-rules',
-  templateUrl: './policy-rule-viewer.component.html',
-  styleUrls: ['./policy-rule-viewer.component.scss']
+  templateUrl: './policy-rule-viewer.component.html'
 })
 export class PolicyRuleViewerComponent {
 

src/app/pages/policies/policy-rule-viewer/policy-rule-viewer.component.scss

@@ -9,8 +9,8 @@ export class ReplacePipe implements PipeTransform {
     }
 
     let result = value;
-    for(let [key,value] of Object.entries(replaceMap)){
-      result = result.replace(new RegExp(`\{\{${key}\}\}`, 'g'), value);
+    for(let [key,val] of Object.entries(replaceMap)){
+      result = result.replace(new RegExp(`\{\{${key}\}\}`, 'g'), val);
     }
 
     return result;

src/app/pages/policies/policy-rule-viewer/policy-rule-viewer.component.ts

@@ -9,7 +9,8 @@
       <mat-paginator [length]="transferProcesses.length" pageSize="transferProcesses.length" hidePageSize="true"></mat-paginator>
     </div>
 
-      <table mat-table [dataSource]="transferProcesses" class="transfer-history-table">
+
+      <table mat-table [dataSource]="transferProcesses" class="transfer-history-table" aria-describedby="Transfer processes">
 
           <ng-container matColumnDef="id">
               <th mat-header-cell *matHeaderCellDef scope="col">Id</th>

src/app/pages/transfer-history/pipes/replace.pipe.ts

@@ -47,7 +47,7 @@ export class TransferHistoryViewerComponent implements OnInit {
   }
 
   showDeprovisionButton(transferProcess: TransferProcess) {
-    return ['COMPLETED', 'PROVISIONED', 'REQUESTED', 'REQUESTED_ACK', 'IN_PROGRESS', 'STREAMING'].includes(transferProcess.state!);
+    return ['COMPLETED', 'PROVISIONED', 'REQUESTED', 'REQUESTED_ACK', 'IN_PROGRESS', 'STREAMING'].includes(transferProcess.state);
   }
 
   loadTransferProcesses() {