Skip to content

Styles refactoring #195

@shackijj

Description

@shackijj

This issue relates to #164 and PR194.

I think that the styles in this project should be refactored for three reasons:

Firstly, not all CSS classes are prefixed. This could lead to bugs when these styles conflict with a website's styles.

Secondly, some styles are applied using a style attribute and others using classes. This makes development and debugging much more difficult.

Thirdly, React components are tightly coupled by their styles. So, for changing the appearance of a component, we have to modify the styles of another component.

Overall, we need to figure out how to write styles for CMP considering all these problems. I see two possible ways inline styles and BEM methodology.

@samtingleff @rusel1989 what do you think about it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions