Refactor saveTemplateCommand to return success status

Changed saveTemplateCommand to return a boolean indicating success or failure instead of void. Updated relevant logic to handle failures gracefully, including error messages and return codes. Incremented version to 1.2.1 in preparation for these updates.

Author: HichemTab-tech

bin/laravelfs

@@ -9,7 +9,7 @@ if (file_exists(__DIR__.'/../../../autoload.php')) {
 }
 
 // Define our own version and the Laravel Installer version we aim to match.
-$laravelFSVersion = '1.2.0';
+$laravelFSVersion = '1.2.1';
 $laravelInstallerVersion = '5.13.0';
 
 // Compose the displayed version string.

src/NewCommand.php

@@ -351,7 +351,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             }
 
             // Save the template globally
-            $this->saveTemplateCommand($templateName, $templateDescription, $templateCommand);
+            if (!$this->saveTemplateCommand($templateName, $templateDescription, $templateCommand)) {
+                error('Failed to save the template.');
+                return Command::FAILURE;
+            }
 
             $output->writeln("  <bg=blue;fg=white> INFO </> Template <options=bold>[$templateName]</> created successfully.");
             $output->writeln("  <fg=gray>➜</> You can now use this template by running <options=bold>laravelfs use $templateName</>");
@@ -1202,7 +1205,7 @@ private function createTemplateCommand(InputInterface $input): string
         return implode(' ', $commandParts);
     }
 
-    protected function saveTemplateCommand(mixed $templateName, mixed $templateDescription, string $templateCommand): void
+    protected function saveTemplateCommand(mixed $templateName, mixed $templateDescription, string $templateCommand): bool
     {
         // Get the global config path for storing templates
         $configPath = $this->getGlobalTemplatesPath();
@@ -1234,6 +1237,15 @@ protected function saveTemplateCommand(mixed $templateName, mixed $templateDescr
             'description' => $templateDescription??"",
             'command' => $templateCommand,
         ];
-        file_put_contents($configPath, json_encode($templatesConfig, JSON_PRETTY_PRINT));
+        $done = file_put_contents($configPath, json_encode($templatesConfig, JSON_PRETTY_PRINT)) !== false;
+        if (!$done) {
+            if (windows_os()) {
+                error('Failed to save the template. Please check the permissions of the directory.');
+            } else {
+                error('Failed to save the template. Please check the permissions of the file or use sudo.');
+            }
+        }
+
+        return $done;
     }
 }

tests/Unit/NewTemplateCommandTest.php

@@ -9,12 +9,13 @@
     // Create a dummy NewTemplateCommand that overrides saveTemplateCommand() to capture the saved template.
     $this->command = new class extends NewTemplateCommand {
         public array|null $savedTemplate = null;
-        public function saveTemplateCommand($templateName, $templateDescription, $templateCommand): void {
+        public function saveTemplateCommand($templateName, $templateDescription, $templateCommand): bool {
             $this->savedTemplate = [
                 'name'        => $templateName,
                 'description' => $templateDescription,
                 'command'     => $templateCommand,
             ];
+            return true;
         }
     };