Compare set expression for output to target expression #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
requested changes
Jan 13, 2022
Member
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
great, thanks for working on this! this will prevent much pain. 👀
i've left a few comments that should be addressed before merging.
added 2 commits
January 13, 2022 15:12
…onal, add test case
jakobj
requested changes
Jan 17, 2022
Member
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
almost done 🚀 left two more comments
jakobj
requested changes
Jan 19, 2022
Member
jakobj
left a comment
jakobj
left a comment
There was a problem hiding this comment.
great, just some leftover to cleanup from when target_expression was optional. 👍
afterwards, please squash commits.
Member
|
ping @HenrikMettler |
HenrikMettler
changed the title
Member
|
Did @HenrikMettler resolve all your comments, @jakobj ? Could you give this another check? |
Member
|
i think i don't have any more pressing comments, besides squashing commits please and fixing tests :) |
Member
|
@HenrikMettler could you fix the tests, rebase on master and squash the commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
genome.set_expression_for_outputone usually has a target expression that the output node should compile to. Since mistakes in setting the dna can happen easily (eg. by changing the order of primitives) - a built-in check can be useful. This PR implements the comparison usingsympy.parse_exprand a compilation to sympy of the genome.