Skip to content

Commit ad7fb7c

Browse files
committed
Fixed bug that wasn't sending the instance to the confirmation message function
1 parent 5889441 commit ad7fb7c

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/Actions/Action.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ private function setMessage($type = 'success', $message = null)
6969

7070
public function shouldBeConfirmed()
7171
{
72-
if (method_exists($this, 'getConfirmationMessage')) {
73-
return !empty($this->getConfirmationMessage(null));
74-
}
75-
76-
return false;
72+
return method_exists($this, 'getConfirmationMessage');
7773
}
7874
}

tests/Feature/ExecuteActionsTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ public function testSeeConfirmationMessage()
6464
]);
6565
}
6666

67+
// TODO: test custom confirmation message
68+
6769
public function testCallActionAfterConfirmationMessage()
6870
{
6971
$user = factory(UserTest::class)->create();

0 commit comments

Comments
 (0)