Skip to content

Commit 0ff9773

Browse files
authored
Merge pull request #174 from Gustavinho/bug/error-messages-displayed-as-success
bug: Error messages are being displayed as success
2 parents 140a89d + 28a93c3 commit 0ff9773

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

.github/workflows/run-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ on:
77
- dev
88
- release/**
99
- feature/**
10+
- bug/**
1011
- tests/**
1112
pull_request:
1213
branches:

resources/views/components/alerts-handler.blade.php

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,18 @@
33
x-init="@this.on('notify', (notification) => {
44
open = true;
55
message = notification.message;
6+
type = notification.type;
67
{{-- setTimeout(() => { open = false }, 2500) --}}
78
})"
89
>
9-
<div x-show='open'>
10-
<template x-if="type === 'danger'">
11-
<x-lv-alert type='danger' onClose='open = false'>
12-
<div x-text='message'></div>
13-
</x-lv-alert>
14-
</template>
15-
<template x-if="type === 'success'">
16-
<x-lv-alert onClose='open = false'>
17-
<div x-text='message'></div>
18-
</x-lv-alert>
19-
</template>
10+
<div x-show="open && type === 'danger'">
11+
<x-lv-alert type='danger' onClose='open = false'>
12+
<div x-text='message'></div>
13+
</x-lv-alert>
14+
</div>
15+
<div x-show="open && type === 'success'">
16+
<x-lv-alert onClose='open = false'>
17+
<div x-text='message'></div>
18+
</x-lv-alert>
2019
</div>
2120
</div>

src/Views/Traits/WithAlerts.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@ private function setMessage($type = 'success', $message = null)
3030
'type' => $type
3131
]);
3232
}
33-
34-
}
33+
}

0 commit comments

Comments
 (0)