Skip to content

fix: fix trace context pattern, remove trace id and respect logging span id field. #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 26, 2024
Merged

fix: fix trace context pattern, remove trace id and respect logging span id field. #667

merged 4 commits into from
Dec 26, 2024

Conversation

@liuyunnnn
Copy link
Contributor

@liuyunnnn liuyunnnn commented Dec 26, 2024 •
edited
Loading

  1. fix trace context pattern (TRACE_CONTEXT_PATTERN expects the options part to always be present, but it can be missing #655)
  2. remove logging.googleapis.com/trace as we don't have project id in functions framework (TRACE format is wrong #656)
  3. respect provided logging.googleapis.com/spanId fields for structured logs

@liuyunnnn liuyunnnn requested a review from nifflets December 26, 2024 19:19
@liuyunnnn liuyunnnn merged commit 0fb00a5 into GoogleCloudPlatform:main Dec 26, 2024
56 checks passed
@release-please release-please bot mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nifflets nifflets nifflets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nifflets nifflets

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liuyunnnn @nifflets