Skip to content

Commit f3a435e

Browse files
committed
fixed issue with vars function
1 parent db5d592 commit f3a435e

File tree

4 files changed

+106
-97
lines changed

4 files changed

+106
-97
lines changed

coverage.out

Lines changed: 94 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,98 @@
11
mode: set
2+
github.com/GolangToolKits/grrt/router.go:29.25,34.2 4 1
3+
github.com/GolangToolKits/grrt/router.go:37.46,39.49 2 1
4+
github.com/GolangToolKits/grrt/router.go:42.2,42.12 1 1
5+
github.com/GolangToolKits/grrt/router.go:39.49,41.3 1 1
6+
github.com/GolangToolKits/grrt/router.go:46.72,49.2 2 1
7+
github.com/GolangToolKits/grrt/reqRoute.go:27.32,31.2 3 1
8+
github.com/GolangToolKits/grrt/reqRoute.go:34.56,35.14 1 1
9+
github.com/GolangToolKits/grrt/reqRoute.go:38.2,38.10 1 1
10+
github.com/GolangToolKits/grrt/reqRoute.go:35.14,37.3 1 1
11+
github.com/GolangToolKits/grrt/reqRoute.go:42.82,44.2 1 1
12+
github.com/GolangToolKits/grrt/reqRoute.go:47.41,48.20 1 1
13+
github.com/GolangToolKits/grrt/reqRoute.go:55.2,55.10 1 1
14+
github.com/GolangToolKits/grrt/reqRoute.go:48.20,50.31 2 1
15+
github.com/GolangToolKits/grrt/reqRoute.go:53.3,53.18 1 1
16+
github.com/GolangToolKits/grrt/reqRoute.go:50.31,52.4 1 1
17+
github.com/GolangToolKits/grrt/reqRoute.go:59.48,60.23 1 1
18+
github.com/GolangToolKits/grrt/reqRoute.go:65.2,65.10 1 1
19+
github.com/GolangToolKits/grrt/reqRoute.go:60.23,64.3 3 1
20+
github.com/GolangToolKits/grrt/reqRoute.go:69.48,71.23 2 1
21+
github.com/GolangToolKits/grrt/reqRoute.go:74.2,75.10 2 1
22+
github.com/GolangToolKits/grrt/reqRoute.go:71.23,73.3 1 1
23+
github.com/GolangToolKits/grrt/reqRoute.go:79.43,81.2 1 1
24+
github.com/GolangToolKits/grrt/reqRoute.go:84.51,86.26 2 1
25+
github.com/GolangToolKits/grrt/reqRoute.go:96.2,96.12 1 1
26+
github.com/GolangToolKits/grrt/reqRoute.go:86.26,88.3 1 1
27+
github.com/GolangToolKits/grrt/reqRoute.go:88.8,89.33 1 1
28+
github.com/GolangToolKits/grrt/reqRoute.go:89.33,90.15 1 1
29+
github.com/GolangToolKits/grrt/reqRoute.go:90.15,92.10 2 1
30+
github.com/GolangToolKits/grrt/reqRoute.go:100.42,102.2 1 1
31+
github.com/GolangToolKits/grrt/reqRoute.go:105.43,107.27 2 1
32+
github.com/GolangToolKits/grrt/reqRoute.go:110.2,110.12 1 1
33+
github.com/GolangToolKits/grrt/reqRoute.go:107.27,109.3 1 1
34+
github.com/GolangToolKits/grrt/reqRoute.go:119.46,121.2 1 1
35+
github.com/GolangToolKits/grrt/reqRoute.go:124.37,126.2 1 1
36+
github.com/GolangToolKits/grrt/reqRoute.go:129.39,131.2 1 1
37+
github.com/GolangToolKits/grrt/reqRoute.go:134.44,136.2 1 1
38+
github.com/GolangToolKits/grrt/reqRoute.go:139.36,141.2 1 1
39+
github.com/GolangToolKits/grrt/reqRoute.go:143.45,145.73 2 1
40+
github.com/GolangToolKits/grrt/reqRoute.go:150.2,150.12 1 1
41+
github.com/GolangToolKits/grrt/reqRoute.go:145.73,147.3 1 1
42+
github.com/GolangToolKits/grrt/reqRoute.go:147.8,149.3 1 1
43+
github.com/GolangToolKits/grrt/reqRoute.go:153.47,158.22 5 1
44+
github.com/GolangToolKits/grrt/reqRoute.go:165.2,165.13 1 1
45+
github.com/GolangToolKits/grrt/reqRoute.go:170.2,170.12 1 1
46+
github.com/GolangToolKits/grrt/reqRoute.go:158.22,159.16 1 1
47+
github.com/GolangToolKits/grrt/reqRoute.go:159.16,161.4 1 1
48+
github.com/GolangToolKits/grrt/reqRoute.go:161.9,161.25 1 1
49+
github.com/GolangToolKits/grrt/reqRoute.go:161.25,163.4 1 1
50+
github.com/GolangToolKits/grrt/reqRoute.go:165.13,167.3 1 1
51+
github.com/GolangToolKits/grrt/reqRoute.go:167.8,169.3 1 1
52+
github.com/GolangToolKits/grrt/reqRoute.go:173.55,180.22 6 1
53+
github.com/GolangToolKits/grrt/reqRoute.go:196.2,196.12 1 1
54+
github.com/GolangToolKits/grrt/reqRoute.go:180.22,181.31 1 1
55+
github.com/GolangToolKits/grrt/reqRoute.go:188.3,188.31 1 1
56+
github.com/GolangToolKits/grrt/reqRoute.go:181.31,184.9 3 1
57+
github.com/GolangToolKits/grrt/reqRoute.go:185.9,185.21 1 1
58+
github.com/GolangToolKits/grrt/reqRoute.go:185.21,187.4 1 1
59+
github.com/GolangToolKits/grrt/reqRoute.go:188.31,191.9 3 1
60+
github.com/GolangToolKits/grrt/reqRoute.go:192.9,192.21 1 1
61+
github.com/GolangToolKits/grrt/reqRoute.go:192.21,194.4 1 1
62+
github.com/GolangToolKits/grrt/reqRoute.go:199.50,203.22 4 1
63+
github.com/GolangToolKits/grrt/reqRoute.go:221.2,221.12 1 1
64+
github.com/GolangToolKits/grrt/reqRoute.go:203.22,204.24 1 1
65+
github.com/GolangToolKits/grrt/reqRoute.go:204.24,207.9 3 1
66+
github.com/GolangToolKits/grrt/reqRoute.go:208.9,208.20 1 1
67+
github.com/GolangToolKits/grrt/reqRoute.go:208.20,209.32 1 1
68+
github.com/GolangToolKits/grrt/reqRoute.go:209.32,212.10 3 1
69+
github.com/GolangToolKits/grrt/reqRoute.go:213.10,213.39 1 1
70+
github.com/GolangToolKits/grrt/reqRoute.go:213.39,215.5 1 1
71+
github.com/GolangToolKits/grrt/reqRoute.go:215.10,215.39 1 1
72+
github.com/GolangToolKits/grrt/reqRoute.go:215.39,218.5 2 1
73+
github.com/GolangToolKits/grrt/reqRoute.go:224.47,228.22 4 1
74+
github.com/GolangToolKits/grrt/reqRoute.go:243.2,243.12 1 1
75+
github.com/GolangToolKits/grrt/reqRoute.go:228.22,229.24 1 1
76+
github.com/GolangToolKits/grrt/reqRoute.go:229.24,232.9 3 1
77+
github.com/GolangToolKits/grrt/reqRoute.go:233.9,233.20 1 1
78+
github.com/GolangToolKits/grrt/reqRoute.go:233.20,234.32 1 1
79+
github.com/GolangToolKits/grrt/reqRoute.go:234.32,237.10 3 1
80+
github.com/GolangToolKits/grrt/reqRoute.go:238.10,238.39 1 1
81+
github.com/GolangToolKits/grrt/reqRoute.go:238.39,240.5 1 1
82+
github.com/GolangToolKits/grrt/reqRoute.go:246.73,255.22 8 1
83+
github.com/GolangToolKits/grrt/reqRoute.go:272.2,272.14 1 1
84+
github.com/GolangToolKits/grrt/reqRoute.go:280.2,280.19 1 1
85+
github.com/GolangToolKits/grrt/reqRoute.go:255.22,256.14 1 1
86+
github.com/GolangToolKits/grrt/reqRoute.go:262.3,262.14 1 1
87+
github.com/GolangToolKits/grrt/reqRoute.go:265.3,265.30 1 1
88+
github.com/GolangToolKits/grrt/reqRoute.go:256.14,258.17 2 1
89+
github.com/GolangToolKits/grrt/reqRoute.go:258.17,260.5 1 1
90+
github.com/GolangToolKits/grrt/reqRoute.go:262.14,264.4 1 1
91+
github.com/GolangToolKits/grrt/reqRoute.go:265.30,270.4 4 1
92+
github.com/GolangToolKits/grrt/reqRoute.go:272.14,273.41 1 1
93+
github.com/GolangToolKits/grrt/reqRoute.go:273.41,275.4 1 1
94+
github.com/GolangToolKits/grrt/reqRoute.go:277.8,279.3 1 1
95+
github.com/GolangToolKits/grrt/reqRoute.go:283.55,287.2 3 1
296
github.com/GolangToolKits/grrt/reqRouter.go:36.71,40.53 1 1
397
github.com/GolangToolKits/grrt/reqRouter.go:40.53,42.3 1 1
498
github.com/GolangToolKits/grrt/reqRouter.go:42.8,45.16 3 1
@@ -59,97 +153,3 @@ github.com/GolangToolKits/grrt/reqRouter.go:214.96,216.36 2 1
59153
github.com/GolangToolKits/grrt/reqRouter.go:221.2,222.27 2 1
60154
github.com/GolangToolKits/grrt/reqRouter.go:216.36,217.32 1 1
61155
github.com/GolangToolKits/grrt/reqRouter.go:217.32,219.4 1 1
62-
github.com/GolangToolKits/grrt/router.go:29.25,34.2 4 1
63-
github.com/GolangToolKits/grrt/router.go:37.46,39.49 2 1
64-
github.com/GolangToolKits/grrt/router.go:42.2,42.12 1 1
65-
github.com/GolangToolKits/grrt/router.go:39.49,41.3 1 1
66-
github.com/GolangToolKits/grrt/router.go:46.72,49.2 2 1
67-
github.com/GolangToolKits/grrt/reqRoute.go:28.32,32.2 3 1
68-
github.com/GolangToolKits/grrt/reqRoute.go:35.56,36.14 1 1
69-
github.com/GolangToolKits/grrt/reqRoute.go:39.2,39.10 1 1
70-
github.com/GolangToolKits/grrt/reqRoute.go:36.14,38.3 1 1
71-
github.com/GolangToolKits/grrt/reqRoute.go:43.82,45.2 1 1
72-
github.com/GolangToolKits/grrt/reqRoute.go:48.41,49.20 1 1
73-
github.com/GolangToolKits/grrt/reqRoute.go:56.2,56.10 1 1
74-
github.com/GolangToolKits/grrt/reqRoute.go:49.20,51.31 2 1
75-
github.com/GolangToolKits/grrt/reqRoute.go:54.3,54.18 1 1
76-
github.com/GolangToolKits/grrt/reqRoute.go:51.31,53.4 1 1
77-
github.com/GolangToolKits/grrt/reqRoute.go:60.48,61.23 1 1
78-
github.com/GolangToolKits/grrt/reqRoute.go:66.2,66.10 1 1
79-
github.com/GolangToolKits/grrt/reqRoute.go:61.23,65.3 3 1
80-
github.com/GolangToolKits/grrt/reqRoute.go:70.48,72.23 2 1
81-
github.com/GolangToolKits/grrt/reqRoute.go:75.2,76.10 2 1
82-
github.com/GolangToolKits/grrt/reqRoute.go:72.23,74.3 1 1
83-
github.com/GolangToolKits/grrt/reqRoute.go:80.43,82.2 1 1
84-
github.com/GolangToolKits/grrt/reqRoute.go:85.51,87.26 2 1
85-
github.com/GolangToolKits/grrt/reqRoute.go:97.2,97.12 1 1
86-
github.com/GolangToolKits/grrt/reqRoute.go:87.26,89.3 1 1
87-
github.com/GolangToolKits/grrt/reqRoute.go:89.8,90.33 1 1
88-
github.com/GolangToolKits/grrt/reqRoute.go:90.33,91.15 1 1
89-
github.com/GolangToolKits/grrt/reqRoute.go:91.15,93.10 2 1
90-
github.com/GolangToolKits/grrt/reqRoute.go:101.42,103.2 1 1
91-
github.com/GolangToolKits/grrt/reqRoute.go:106.43,108.27 2 1
92-
github.com/GolangToolKits/grrt/reqRoute.go:111.2,111.12 1 1
93-
github.com/GolangToolKits/grrt/reqRoute.go:108.27,110.3 1 1
94-
github.com/GolangToolKits/grrt/reqRoute.go:120.46,122.2 1 1
95-
github.com/GolangToolKits/grrt/reqRoute.go:125.37,127.2 1 1
96-
github.com/GolangToolKits/grrt/reqRoute.go:130.39,132.2 1 1
97-
github.com/GolangToolKits/grrt/reqRoute.go:135.44,137.2 1 1
98-
github.com/GolangToolKits/grrt/reqRoute.go:140.36,142.2 1 1
99-
github.com/GolangToolKits/grrt/reqRoute.go:144.45,146.73 2 1
100-
github.com/GolangToolKits/grrt/reqRoute.go:151.2,151.12 1 1
101-
github.com/GolangToolKits/grrt/reqRoute.go:146.73,148.3 1 1
102-
github.com/GolangToolKits/grrt/reqRoute.go:148.8,150.3 1 1
103-
github.com/GolangToolKits/grrt/reqRoute.go:154.47,159.22 5 1
104-
github.com/GolangToolKits/grrt/reqRoute.go:166.2,166.13 1 1
105-
github.com/GolangToolKits/grrt/reqRoute.go:171.2,171.12 1 1
106-
github.com/GolangToolKits/grrt/reqRoute.go:159.22,160.16 1 1
107-
github.com/GolangToolKits/grrt/reqRoute.go:160.16,162.4 1 1
108-
github.com/GolangToolKits/grrt/reqRoute.go:162.9,162.25 1 1
109-
github.com/GolangToolKits/grrt/reqRoute.go:162.25,164.4 1 1
110-
github.com/GolangToolKits/grrt/reqRoute.go:166.13,168.3 1 1
111-
github.com/GolangToolKits/grrt/reqRoute.go:168.8,170.3 1 1
112-
github.com/GolangToolKits/grrt/reqRoute.go:174.55,181.22 6 1
113-
github.com/GolangToolKits/grrt/reqRoute.go:197.2,197.12 1 1
114-
github.com/GolangToolKits/grrt/reqRoute.go:181.22,182.31 1 1
115-
github.com/GolangToolKits/grrt/reqRoute.go:189.3,189.31 1 1
116-
github.com/GolangToolKits/grrt/reqRoute.go:182.31,185.9 3 1
117-
github.com/GolangToolKits/grrt/reqRoute.go:186.9,186.21 1 1
118-
github.com/GolangToolKits/grrt/reqRoute.go:186.21,188.4 1 1
119-
github.com/GolangToolKits/grrt/reqRoute.go:189.31,192.9 3 1
120-
github.com/GolangToolKits/grrt/reqRoute.go:193.9,193.21 1 1
121-
github.com/GolangToolKits/grrt/reqRoute.go:193.21,195.4 1 1
122-
github.com/GolangToolKits/grrt/reqRoute.go:200.50,204.22 4 1
123-
github.com/GolangToolKits/grrt/reqRoute.go:222.2,222.12 1 1
124-
github.com/GolangToolKits/grrt/reqRoute.go:204.22,205.24 1 1
125-
github.com/GolangToolKits/grrt/reqRoute.go:205.24,208.9 3 1
126-
github.com/GolangToolKits/grrt/reqRoute.go:209.9,209.20 1 1
127-
github.com/GolangToolKits/grrt/reqRoute.go:209.20,210.32 1 1
128-
github.com/GolangToolKits/grrt/reqRoute.go:210.32,213.10 3 1
129-
github.com/GolangToolKits/grrt/reqRoute.go:214.10,214.39 1 1
130-
github.com/GolangToolKits/grrt/reqRoute.go:214.39,216.5 1 1
131-
github.com/GolangToolKits/grrt/reqRoute.go:216.10,216.39 1 1
132-
github.com/GolangToolKits/grrt/reqRoute.go:216.39,219.5 2 1
133-
github.com/GolangToolKits/grrt/reqRoute.go:225.47,229.22 4 1
134-
github.com/GolangToolKits/grrt/reqRoute.go:244.2,244.12 1 1
135-
github.com/GolangToolKits/grrt/reqRoute.go:229.22,230.24 1 1
136-
github.com/GolangToolKits/grrt/reqRoute.go:230.24,233.9 3 1
137-
github.com/GolangToolKits/grrt/reqRoute.go:234.9,234.20 1 1
138-
github.com/GolangToolKits/grrt/reqRoute.go:234.20,235.32 1 1
139-
github.com/GolangToolKits/grrt/reqRoute.go:235.32,238.10 3 1
140-
github.com/GolangToolKits/grrt/reqRoute.go:239.10,239.39 1 1
141-
github.com/GolangToolKits/grrt/reqRoute.go:239.39,241.5 1 1
142-
github.com/GolangToolKits/grrt/reqRoute.go:247.73,256.22 8 1
143-
github.com/GolangToolKits/grrt/reqRoute.go:273.2,273.14 1 1
144-
github.com/GolangToolKits/grrt/reqRoute.go:281.2,281.19 1 1
145-
github.com/GolangToolKits/grrt/reqRoute.go:256.22,257.14 1 1
146-
github.com/GolangToolKits/grrt/reqRoute.go:263.3,263.14 1 1
147-
github.com/GolangToolKits/grrt/reqRoute.go:266.3,266.30 1 1
148-
github.com/GolangToolKits/grrt/reqRoute.go:257.14,259.17 2 1
149-
github.com/GolangToolKits/grrt/reqRoute.go:259.17,261.5 1 1
150-
github.com/GolangToolKits/grrt/reqRoute.go:263.14,265.4 1 1
151-
github.com/GolangToolKits/grrt/reqRoute.go:266.30,271.4 4 1
152-
github.com/GolangToolKits/grrt/reqRoute.go:273.14,274.41 1 1
153-
github.com/GolangToolKits/grrt/reqRoute.go:274.41,276.4 1 1
154-
github.com/GolangToolKits/grrt/reqRoute.go:278.8,280.3 1 1
155-
github.com/GolangToolKits/grrt/reqRoute.go:284.55,288.2 3 1

reqRoute.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212

1313
// ReqRoute ReqRoute
1414
type ReqRoute struct {
15-
//namedRoutes map[string]*Route
1615
handler http.Handler
1716
host string
1817
path string
@@ -172,7 +171,7 @@ func (t *ReqRoute) chechCurlys(p string) bool {
172171
}
173172

174173
func (t *ReqRoute) chechCurlyPlacement(p string) bool {
175-
//checks to make sure there are no {{ of }}
174+
//checks to make sure there are no {{ or }} missmatch
176175
var rtn = true
177176
oc := rune('{')
178177
cc := rune('}')

router.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ func NewRouter() Router {
3535

3636
// Vars Vars returns the path variables for the current request
3737
func Vars(r *http.Request) map[string]string {
38-
var rtn map[string]string
38+
var rtn = make(map[string]string)
3939
if rv := r.Context().Value(varsKey); rv != nil {
4040
rtn = rv.(map[string]string)
4141
}

router_test.go

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@ func TestVars(t *testing.T) {
4242
m1["param1"] = "p1"
4343
m1["param2"] = "p2"
4444

45+
tr2, _ := http.NewRequest("GET", "/test/test1/p1/p2", nil)
46+
m2 := make(map[string]string)
47+
4548
type args struct {
4649
r *http.Request
4750
}
@@ -58,6 +61,13 @@ func TestVars(t *testing.T) {
5861
},
5962
want: m1,
6063
},
64+
{
65+
name: "test 2",
66+
args: args{
67+
r: tr2,
68+
},
69+
want: m2,
70+
},
6171
}
6272
for _, tt := range tests {
6373
t.Run(tt.name, func(t *testing.T) {

0 commit comments

Comments
 (0)