Implemented test for OFB & small fixes to OFB...

Author: Glindeb

.github/workflows/core.yml

@@ -65,9 +65,9 @@ jobs:
         uses: 'marvinpinto/action-automatic-releases@latest'
         with:
           repo_token: ${{ secrets.RELEASE_TOKEN }}
-          automatic_release_tag: v1.1.6
+          automatic_release_tag: v1.2.0
           prerelease: false
-          title: v1.1.6
+          title: v1.2.0
           files: |
             dist/*
 

README.md

@@ -21,7 +21,7 @@ Implemented running modes
 - [x] **CBC** - Cipher Block Chaining mode (For more information see ...)
 - [x] **PCBC** - Propagating Cipher Block Chaining mode (For more information see ...)
 - [ ] **CFB** - Cipher Feedback mode (For more information see ...)
-- [ ] **OFB** - Output FeedBack mode (For more information see ...)
+- [x] **OFB** - Output FeedBack mode (For more information see ...)
 - [ ] **CTR** - Counter mode (For more information see ...)
 - [ ] **GCM** - Galois/Counter mode (For more information see ...)
 

src/PyAES/AES.py

@@ -592,12 +592,13 @@ def ofb_enc(key, file_path, iv, terminal_width=80):
     file_size = getsize(file_path)
     progress = 0
     progress = progress_bar(progress, file_size, terminal_width)
-    iv = [int(iv[i:i+2], 16) for i in range(0, len(iv), 2)]
+    mix = [int(iv[i:i+2], 16) for i in range(0, len(iv), 2)]
+    iv = mix
 
     with open(f"{file_path}.enc", 'wb') as output, open(file_path, 'rb') as data:
         for i in range(int(file_size/16)):
             raw = [i for i in data.read(16)]
-            mix = encryption_rounds(iv, key)
+            mix = encryption_rounds(mix, key)
             result = xor(raw, mix)
             output.write(bytes(result))
             progress = progress_bar(progress, file_size, terminal_width)
@@ -618,9 +619,9 @@ def ofb_enc(key, file_path, iv, terminal_width=80):
             output.write(bytes(result + identifier))
             progress = progress_bar(progress, file_size, terminal_width)
         else:
-            mix = bytes(encryption_rounds(mix, key))
+            mix = encryption_rounds(mix, key)
             identifier = xor([0 for i in range(16)], mix)
-            output.write(identifier)
+            output.write(bytes(identifier))
             progress = progress_bar(progress, file_size, terminal_width)
     progress = progress_bar(progress, file_size, terminal_width)
     remove(file_path)
@@ -665,4 +666,4 @@ def ofb_dec(key, file_path, iv, terminal_width=80):
         output.write(result)
         progress = progress_bar(progress, file_size, terminal_width)
     progress = progress_bar(progress, file_size, terminal_width)
-    remove(file_path)
+    remove(file_path)

src/PyAES/__init__.py

@@ -19,7 +19,7 @@
 __copyright__ = 'Copyright 2022, Gabriel Lindeblad'
 __credits__ = [""]
 __license__ = 'MIT'
-__version__ = '1.1.6'
+__version__ = '1.2.0'
 __maintainer__ = 'Gabriel Lindeblad'
 __email__ = 'Gabriel.lindeblad@icloud.com'
 __status__ = 'Development'

src/PyAES/decrypt.py

@@ -23,6 +23,8 @@ def decrypt(key, file_path, running_mode, iv=None, terminal_size=80):
         AES.cbc_dec(key, file_path, iv, terminal_size)
     elif running_mode == "PCBC" and iv is not None:
         AES.pcbc_dec(key, file_path, iv, terminal_size)
+    elif running_mode == "OFB" and iv is not None:
+        AES.ofb_dec(key, file_path, iv, terminal_size)
     else:
         raise Exception("Running mode not supported")
 

src/PyAES/encrypt.py

@@ -21,6 +21,8 @@ def encrypt(key, file_path, running_mode, iv=None, terminal_size=80):
         AES.cbc_enc(key, file_path, iv, terminal_size)
     elif running_mode == "PCBC" and iv is not None:
         AES.pcbc_enc(key, file_path, iv, terminal_size)
+    elif running_mode == "OFB" and iv is not None:
+        AES.ofb_enc(key, file_path, iv, terminal_size)
     else:
         raise Exception("Running mode not supported")
 

tests/test_decryption.py

@@ -27,6 +27,7 @@ def test_aes_decryption_ECB(data, key, file_name, expected):
 
     assert result == expected
 
+
 @pytest.mark.parametrize("data,key,file_name,iv,expected", [
     # 128 bit
     (b'\xe4\xa7\x0e\xbd\x84\xfa\xf5\xd8`\xb8\xa1\x10\x0b~\xadh\x89Feso\xc5~_|\xe9\x1bG\xd9*\\\x81', "2b7e151628aed2a6abf7158809cf4f3c", "tmp1.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890'),
@@ -53,6 +54,7 @@ def test_aes_decryption_CBC(data, key, file_name, iv, expected):
 
     assert result == expected
 
+
 @pytest.mark.parametrize("data,key,file_name,iv,expected", [
     # 128 bit
     (b'\xe4\xa7\x0e\xbd\x84\xfa\xf5\xd8`\xb8\xa1\x10\x0b~\xadhJ\xa98\x9f\xceZ\xd4\x9f"\xde\x00\xf6w\xa9\x1b\x05', "2b7e151628aed2a6abf7158809cf4f3c", "tmp1.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890'),
@@ -78,3 +80,30 @@ def test_aes_decryption_PCBC(data, key, file_name, iv, expected):
     os.remove(file_name)
 
     assert result == expected
+
+
+@pytest.mark.parametrize("data,key,file_name,iv,expected", [
+    # 128 bit
+    (b'a\xccT\xf8\xac[\x05\x8e\xe397\xe9\x9b\xaf\xec`\xd9\xa4\xda\xda\x08\x92#\x9fk\x8b=v\x80\xe1Vr', "2b7e151628aed2a6abf7158809cf4f3c", "tmp1.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890'),
+    (b'a\xccT\xf8\xac[\x05\x8e\xe39\x06\xdb\xa8\x9b\xd9V\xd9\xa4\xda\xda\x08\x92#\x9fk\x8b=v\x80\xe1Vt', "2b7e151628aed2a6abf7158809cf4f3c", "tmp2.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890123456'),
+    (b'a\xccT\xf8\xac[\x05\x8e\xe39\x06\xdb\xa8\x9b\xd9V\xee\x9c\xe3\xea\x08\x92#\x9fk\x8b=v\x80\xe1Vt\xa7\x88\x19X?\x03\x08\xe7\xa6\xbf6\xb18j\xbf/', "2b7e151628aed2a6abf7158809cf4f3c", "tmp7.txt", "000102030405060708090a0b0c0d0e0f", b'12345678901234567890'),
+    (b"a\xccT\xf8\xac[\x05\x8e\xe39\x06\xdb\xa8\x9b\xd9V\xee\x9c\xe3\xea9\xa0\x10\xab^\xbd\nN\xb9\xd1gF\x94\xbc,n\x08;1\xd7\xa6\xbf6\xb18j\xbf#\xc6\xd3Am)\x16\\o\xcb\x8eQ\xa2'\xba\x99F", "2b7e151628aed2a6abf7158809cf4f3c", "tmp8.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890123456789012345678901234567890'),
+    # 192 bit
+    (b"\x97;\x80\xb9\xc6\x87$\x05\xe4\xcf'\x18\xba\tV^R\xef\x01\xdaR`/\xe0\x97_x\xac\x84\xbf\x8aV", "8e73b0f7da0e6452c810f32b809079e562f8ead2522c6b7b", "tmp3.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890'),
+    (b'\x97;\x80\xb9\xc6\x87$\x05\xe4\xcf\x16*\x89=chR\xef\x01\xdaR`/\xe0\x97_x\xac\x84\xbf\x8aP', "8e73b0f7da0e6452c810f32b809079e562f8ead2522c6b7b", "tmp4.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890123456'),
+    # 256 bit
+    (b'\x86\x8d\ti\xc1\x0f\xbe\xe5\xae\xc0\xfa\x97\xeb\xce/J\xe1\xc6V0^\xd1\xa7\xa6V8\x05to\xe0>\xda', "603deb1015ca71be2b73aef0857d77811f352c073b6108d72d9810a30914dff4", "tmp5.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890'),
+    (b'\x86\x8d\ti\xc1\x0f\xbe\xe5\xae\xc0\xcb\xa5\xd8\xfa\x1a|\xe1\xc6V0^\xd1\xa7\xa6V8\x05to\xe0>\xdc', "603deb1015ca71be2b73aef0857d77811f352c073b6108d72d9810a30914dff4", "tmp6.txt", "000102030405060708090a0b0c0d0e0f", b'1234567890123456')
+])
+def test_aes_decryption_OFB(data, key, file_name, iv, expected):
+    with open(f"{file_name}.enc", "wb") as file:
+        file.write(data)
+
+    decrypt(key, f"{file_name}.enc", "OFB", iv)
+
+    with open(file_name, "rb") as file:
+        result = file.read()
+
+    os.remove(file_name)
+
+    assert result == expected

tests/test_encryption.py

@@ -26,6 +26,7 @@ def test_aes_encrypt_ECB(data, key, file_name, expected):
 
     assert result == expected
 
+
 @pytest.mark.parametrize("data,key,file_name,iv,expected", [
     # 128 bit
     (b'1234567890', "2b7e151628aed2a6abf7158809cf4f3c", "tmp.txt", "000102030405060708090a0b0c0d0e0f", b'\xe4\xa7\x0e\xbd\x84\xfa\xf5\xd8`\xb8\xa1\x10\x0b~\xadh\x89Feso\xc5~_|\xe9\x1bG\xd9*\\\x81'),
@@ -50,6 +51,7 @@ def test_aes_encrypt_CBC(data, key, file_name, iv, expected):
 
     assert result == expected
 
+
 @pytest.mark.parametrize("data,key,file_name,iv,expected", [
     # 128 bit
     (b'1234567890', "2b7e151628aed2a6abf7158809cf4f3c", "tmp.txt", "000102030405060708090a0b0c0d0e0f", b'\xe4\xa7\x0e\xbd\x84\xfa\xf5\xd8`\xb8\xa1\x10\x0b~\xadhJ\xa98\x9f\xceZ\xd4\x9f"\xde\x00\xf6w\xa9\x1b\x05'),
@@ -72,4 +74,29 @@ def test_aes_encrypt_PCBC(data, key, file_name, iv, expected):
 
     os.remove(f"{file_name}.enc")
 
-    assert result == expected
+    assert result == expected
+
+
+@pytest.mark.parametrize("data,key,file_name,iv,expected", [
+    # 128 bit
+    (b'1234567890', "2b7e151628aed2a6abf7158809cf4f3c", "tmp.txt", "000102030405060708090a0b0c0d0e0f", b'a\xccT\xf8\xac[\x05\x8e\xe397\xe9\x9b\xaf\xec`\xd9\xa4\xda\xda\x08\x92#\x9fk\x8b=v\x80\xe1Vr'),
+    (b'1234567890123456', "2b7e151628aed2a6abf7158809cf4f3c", "tmp1.txt", "000102030405060708090a0b0c0d0e0f", b'a\xccT\xf8\xac[\x05\x8e\xe39\x06\xdb\xa8\x9b\xd9V\xd9\xa4\xda\xda\x08\x92#\x9fk\x8b=v\x80\xe1Vt'),
+    # 192 bit
+    (b'1234567890', "8e73b0f7da0e6452c810f32b809079e562f8ead2522c6b7b", "tmp2.txt", "000102030405060708090a0b0c0d0e0f", b"\x97;\x80\xb9\xc6\x87$\x05\xe4\xcf'\x18\xba\tV^R\xef\x01\xdaR`/\xe0\x97_x\xac\x84\xbf\x8aV"),
+    (b'1234567890123456', "8e73b0f7da0e6452c810f32b809079e562f8ead2522c6b7b", "tmp3.txt", "000102030405060708090a0b0c0d0e0f", b'\x97;\x80\xb9\xc6\x87$\x05\xe4\xcf\x16*\x89=chR\xef\x01\xdaR`/\xe0\x97_x\xac\x84\xbf\x8aP'),
+    # 256 bit
+    (b'1234567890', "603deb1015ca71be2b73aef0857d77811f352c073b6108d72d9810a30914dff4", "tmp4.txt", "000102030405060708090a0b0c0d0e0f", b'\x86\x8d\ti\xc1\x0f\xbe\xe5\xae\xc0\xfa\x97\xeb\xce/J\xe1\xc6V0^\xd1\xa7\xa6V8\x05to\xe0>\xda'),
+    (b'1234567890123456', "603deb1015ca71be2b73aef0857d77811f352c073b6108d72d9810a30914dff4", "tmp5.txt", "000102030405060708090a0b0c0d0e0f", b'\x86\x8d\ti\xc1\x0f\xbe\xe5\xae\xc0\xcb\xa5\xd8\xfa\x1a|\xe1\xc6V0^\xd1\xa7\xa6V8\x05to\xe0>\xdc')
+])
+def test_aes_encrypt_OFB(data, key, file_name, iv, expected):
+    with open(file_name, "wb") as file:
+        file.write(data)
+
+    encrypt(key, file_name, "OFB", iv)
+
+    with open(f"{file_name}.enc", "rb") as file:
+        result = file.read()
+
+    os.remove(f"{file_name}.enc")
+
+    assert result == expected

tmp/test_2.py

@@ -1,31 +1,6 @@
-from matplotlib import pyplot as plt
-
-# Set the figure size
-plt.rcParams["figure.figsize"] = [5.00, 5.00]
-plt.rcParams["figure.autolayout"] = True
-
-
-# Random data points
-#with open("/Users/gabriellindeblad/Documents/GitHub/AES-Python/tmp/test_files/data.txt.enc", "rb") as f:
-#    data = f.read().splitlines()
-#    print(data)
-#    for index, pice in enumerate(data):
-#        data[index] = [i for i in pice]
-
 with open("/Users/gabriellindeblad/Documents/GitHub/AES-Python/tmp/test_files/data.txt.enc", "rb") as f:
     data = f.read()
-    data = [i for i in data]
-    data = [data[x:x+192] for x in range(0, len(data), 192)]
-    #data = data[:-1]
-print(data)
 
 print(data)
+print(len(data))
 
-
-plt.title('adjust axis scale')
-
-# Plot the data using imshow with gray colormap & aspect set to auto
-plt.imshow(data, interpolation=None, cmap="gray", aspect="auto")
-
-# Display the plot
-plt.show()

tmp/test_3.py

@@ -1,7 +1,7 @@
 from PyAES.AES import ofb_dec, ofb_enc
 
 def run(val):
-    key = "2b7e151628aed2a6abf7158809cf4f3c"
+    key = "603deb1015ca71be2b73aef0857d77811f352c073b6108d72d9810a30914dff4"
     iv = "000102030405060708090a0b0c0d0e0f"
     file_path = r"/Users/gabriellindeblad/Documents/GitHub/AES-Python/tmp/test_files/data.txt"
 
@@ -12,4 +12,3 @@ def run(val):
 
 if __name__ == "__main__":
     run(2)
-    print("Done!")