Merge pull request #7 from GitLiveApp/dynamic-target-collection-path

Fix dynamic target collection path params bug

Author: nbransby

src/rules/deleteReferences.ts

@@ -76,16 +76,10 @@ export function integrifyDeleteReferences(
           );
         }
 
-        // Replace the context.params in the target collection
-        const paramSwap = replaceReferencesWith(
-          context.params,
-          target.collection
-        );
-
-        // Replace the snapshot fields in the target collection
+        // Replace the context.params and snapshot fields in the target collection
         const fieldSwap = replaceReferencesWith(
-          snap.data(),
-          paramSwap.targetCollection
+          { ...snap.data(), ...context.params },
+          target.collection
         );
         target.collection = fieldSwap.targetCollection;
 

test/unit.test.js

@@ -384,7 +384,6 @@ async function testDeleteSnapshotFieldReferences(sut, t, name) {
   await wrapped(snap, {
     params: {
       anotherId: anotherId,
-      testId: testId,
     },
   });