fix(replicateAttributes): Always delete missing fields

Author: michaelprichardson

README.md

@@ -36,7 +36,7 @@ module.exports.replicateMasterToDetail = integrify({
       collection: 'detail1',
       foreignKey: 'masterId',
       attributeMapping: {
-        masterField1: 'detail1Field1',
+        masterField1: 'detail1Field1', // If an field is missing after the update, the field will be deleted
         masterField2: 'detail1Field2',
       },
     },

src/rules/replicateAttributes.ts

@@ -13,7 +13,6 @@ export interface ReplicateAttributesRule extends Rule {
       [sourceAttribute: string]: string;
     };
     isCollectionGroup?: boolean;
-    deleteMissing?: boolean;
   }[];
   hooks?: {
     pre?: Function;
@@ -99,23 +98,12 @@ export function integrifyReplicateAttributes(
       rule.targets.forEach(target => {
         const targetCollection = target.collection;
         const update = {};
-        let shouldDelete = false;
-
-        if (target.deleteMissing) {
-          shouldDelete = target.deleteMissing;
-        }
 
         // Create "update" mapping each changed attribute from source => target,
         // if delete is set delete field
         Object.keys(target.attributeMapping).forEach(changedAttribute => {
-          if (newValue[changedAttribute]) {
-            update[target.attributeMapping[changedAttribute]] =
-              newValue[changedAttribute];
-          } else if (shouldDelete) {
-            update[
-              target.attributeMapping[changedAttribute]
-            ] = FieldValue.delete();
-          }
+          update[target.attributeMapping[changedAttribute]] =
+            newValue[changedAttribute] || FieldValue.delete();
         });
 
         console.log(