-
Notifications
You must be signed in to change notification settings - Fork 6
devcontainer improvements #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer improvements #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the devcontainer setup by installing the CodeQL CLI, switching to a more reliable Python environment management extension, and improving user visibility of setup messages through a new post-attach script.
- CodeQL CLI installation added to the Dockerfile
- Switched from manual Python interpreter settings to
ms-python.vscode-python-envsextension for better environment management - Moved user-facing messages from
post-create.shto newpost-attach.shscript for better visibility
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .devcontainer/Dockerfile | Adds CodeQL CLI installation during container build |
| .devcontainer/devcontainer.json | Updates Python environment settings and adds post-attach command |
| .devcontainer/post-create.sh | Streamlines setup script, removes Codespaces checks, simplifies .env creation |
| .devcontainer/post-attach.sh | New script for displaying user-facing messages and checking Codespaces secrets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
A few improvements to the devcontainer:
.venvenvironment was very unreliable. It seems that ms-python.vscode-python-envs is the recommended solution.post-create.shwere only going to the creation log and not shown to the user. I added apost-attach.shscript which seems to work better.