Skip to content

Conversation

@kevinbackhouse
Copy link
Collaborator

A few improvements to the devcontainer:

  1. Install the CodeQL CLI.
  2. I found that the automatic loading of the .venv environment was very unreliable. It seems that ms-python.vscode-python-envs is the recommended solution.
  3. The messages from post-create.sh were only going to the creation log and not shown to the user. I added a post-attach.sh script which seems to work better.

Copilot AI review requested due to automatic review settings November 23, 2025 11:35
Copilot finished reviewing on behalf of kevinbackhouse November 23, 2025 11:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the devcontainer setup by installing the CodeQL CLI, switching to a more reliable Python environment management extension, and improving user visibility of setup messages through a new post-attach script.

  • CodeQL CLI installation added to the Dockerfile
  • Switched from manual Python interpreter settings to ms-python.vscode-python-envs extension for better environment management
  • Moved user-facing messages from post-create.sh to new post-attach.sh script for better visibility

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.devcontainer/Dockerfile Adds CodeQL CLI installation during container build
.devcontainer/devcontainer.json Updates Python environment settings and adds post-attach command
.devcontainer/post-create.sh Streamlines setup script, removes Codespaces checks, simplifies .env creation
.devcontainer/post-attach.sh New script for displaying user-facing messages and checking Codespaces secrets

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 23, 2025 11:51
Copilot finished reviewing on behalf of kevinbackhouse November 23, 2025 11:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 23, 2025 15:31
Copilot finished reviewing on behalf of kevinbackhouse November 23, 2025 15:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 23, 2025 15:41
Copilot finished reviewing on behalf of kevinbackhouse November 23, 2025 15:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kevinbackhouse kevinbackhouse merged commit bcca42b into GitHubSecurityLab:main Nov 24, 2025
15 checks passed
@kevinbackhouse kevinbackhouse deleted the devcontainer-improvements branch November 24, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants