Skip to content

feat(auth): enable OS port selection for OAuth server Use port 0 to … #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(auth): enable OS port selection for OAuth server Use port 0 to … #1152

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
463e611
feat(auth): enable OS port selection for OAuth server Use port 0 to …
harsha08-2k6 Nov 24, 2025
704e9aa
fix: remove invalid method call
harsha08-2k6 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions ggshield/verticals/auth/oauth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def oauth_process(
if extra_scopes is not None:
self._extra_scopes = extra_scopes

self._prepare_server()
Copy link
Collaborator

@sevbch sevbch Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since your removed that line, the program is never entering in _prepare_server method that you edited below.

self.158()
Copy link
Collaborator

@sevbch sevbch Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this looks like a typo.

Copy link
Author

@harsha08-2k6 harsha08-2k6 Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, thanks for catching that! Fixed in 704e9aa.

self._redirect_to_login()
self._wait_for_callback()
self._print_login_success()
Expand Down Expand Up @@ -163,20 +163,11 @@ def _redirect_to_login(self) -> None:
webbrowser.open_new_tab(request_uri)

def _prepare_server(self) -> None:
for port in range(*USABLE_PORT_RANGE):
try:
self.server = HTTPServer(
# only consider requests from localhost on the predetermined port
("127.0.0.1", port),
functools.partial(RequestHandler, self),
)
self._port = port
break
except OSError:
continue
else:
raise UnexpectedError("Could not find unoccupied port.")

self.server = HTTPServer(
("127.0.0.1", 0),
functools.partial(RequestHandler, self),
)
self._port = self.server.server_port
def _wait_for_callback(self) -> None:
"""
Wait to receive and process the authorization callback on the local server.
Expand Down