Skip to content

Commit 6ba9f31

Browse files
committed
fix(is_loadable): adapt is_loadable to return a Percentage instead of bool
1 parent 263faed commit 6ba9f31

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/opengeodeweb_back/geode_functions.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@ def additional_files(geode_object: str, file_absolute_path: str):
3232
return geode_object_value(geode_object)["additional_files"](file_absolute_path)
3333

3434

35-
def is_loadable(geode_object: str, file_absolute_path: str):
36-
return geode_object_value(geode_object)["is_loadable"](file_absolute_path)
35+
def is_loadable(geode_object: str, file_absolute_path: str) -> float:
36+
percentage = geode_object_value(geode_object)["is_loadable"](file_absolute_path)
37+
return percentage.value()
3738

3839

3940
def load(geode_object: str, file_absolute_path: str):
@@ -183,8 +184,10 @@ def list_geode_objects(
183184

184185
for geode_object in geode_objects_filtered_list:
185186
if has_creator(geode_object, file_extension):
186-
file_is_loadable = is_loadable(geode_object, file_absolute_path)
187-
return_dict[geode_object] = {"is_loadable": file_is_loadable}
187+
loadability_score = is_loadable(geode_object, file_absolute_path)
188+
return_dict[geode_object] = {
189+
"is_loadable": loadability_score
190+
}
188191
return return_dict
189192

190193

tests/test_geode_functions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,8 @@ def test_is_loadable():
6363
for input_extension in input_extensions:
6464
file_absolute_path = os.path.join(data_folder, f"test.{input_extension}")
6565
is_loadable = geode_functions.is_loadable(geode_object, file_absolute_path)
66-
assert type(is_loadable) is bool
66+
assert isinstance(is_loadable, float)
67+
assert 0.0 <= is_loadable <= 1.0
6768

6869

6970
def test_load():
@@ -296,7 +297,8 @@ def test_list_geode_objects():
296297
input_extension,
297298
input_extension_value,
298299
) in input_extension_dict.items():
299-
assert type(input_extension_value) is bool
300+
assert isinstance(input_extension_value, float)
301+
assert 0.0 <= input_extension_value <= 1.0
300302

301303

302304
def test_geode_objects_output_extensions():

0 commit comments

Comments
 (0)